Skip to content

[ENG-12371][eas-cli] allow user to select package manager when doing onboarding#2402

Draft
szdziedzic wants to merge 2 commits intomainfrom
@szdziedzic/allow-user-to-select-package-manager-when-doing-onboarding
Draft

[ENG-12371][eas-cli] allow user to select package manager when doing onboarding#2402
szdziedzic wants to merge 2 commits intomainfrom
@szdziedzic/allow-user-to-select-package-manager-when-doing-onboarding

Conversation

@szdziedzic
Copy link
Copy Markdown
Contributor

Why

allow the user to select package manager when doing onboarding

How

allow the user to select package manager when doing onboarding

Test Plan

Screenshot 2024-05-29 at 10 35 02 Screenshot 2024-05-29 at 10 32 04

@szdziedzic szdziedzic changed the title [eas-cli] allow user to select package manager when doing onboarding [ENG-12371][eas-cli] allow user to select package manager when doing onboarding May 29, 2024
@linear
Copy link
Copy Markdown

linear Bot commented May 29, 2024

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2024

Size Change: -201 B (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB -201 B (0%)

compressed-size-action

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2024

Codecov Report

❌ Patch coverage is 8.16327% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.29%. Comparing base (f0e3b64) to head (7fa26ed).
⚠️ Report is 922 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/onboarding/packageManagers.ts 8.34% 30 Missing and 3 partials ⚠️
...ackages/eas-cli/src/commands/project/onboarding.ts 7.70% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2402      +/-   ##
==========================================
- Coverage   53.40%   53.29%   -0.11%     
==========================================
  Files         530      531       +1     
  Lines       19527    19575      +48     
  Branches     3967     3976       +9     
==========================================
+ Hits        10427    10431       +4     
- Misses       8348     8389      +41     
- Partials      752      755       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@szdziedzic
Copy link
Copy Markdown
Contributor Author

/changelog-entry new-feature Allow selecting package manager when doing onboarding

@github-actions
Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic marked this pull request as draft August 22, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants