Skip to content

feature(eas-cli): add worker:alias --json support for 3rd parties and custom tooling#2562

Merged
byCedric merged 6 commits intomainfrom
@bycedric/eas-cli/worker-alias-json
Sep 13, 2024
Merged

feature(eas-cli): add worker:alias --json support for 3rd parties and custom tooling#2562
byCedric merged 6 commits intomainfrom
@bycedric/eas-cli/worker-alias-json

Conversation

@byCedric
Copy link
Copy Markdown
Member

Why

With eas worker:alias --json, we can integrate with other tooling (such as expo-github-action). This adds support for exactly that.

How

  • Swapped the beta warning from Log.warn to console.warn, avoiding polluting the JSON output
  • Added --json only output to eas worker:alias --json command

Test Plan

eas worker:alias --json image
eas worker:alias --id xxx --json image
eas worker:alias --alias pr-test --json image
eas worker:alias --id xxx --alias pr-test --json image

Comment thread packages/eas-cli/src/commands/worker/alias.ts Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 13, 2024

Size Change: -537 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -537 B (0%)

compressed-size-action

@github-actions
Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 20 lines in your changes missing coverage. Please review.

Project coverage is 52.19%. Comparing base (fa32629) to head (1dbe806).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/worker/alias.ts 9.10% 14 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2562      +/-   ##
==========================================
- Coverage   52.21%   52.19%   -0.02%     
==========================================
  Files         557      557              
  Lines       21021    21035      +14     
  Branches     4300     4304       +4     
==========================================
+ Hits        10975    10977       +2     
- Misses       9179     9187       +8     
- Partials      867      871       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byCedric byCedric merged commit 47e1989 into main Sep 13, 2024
@byCedric byCedric deleted the @bycedric/eas-cli/worker-alias-json branch September 13, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants