Conversation
…deployments This also includes some clean ups and log utility sharing
|
Size Change: +680 B (0%) Total Size: 52.9 MB
|
kadikraman
left a comment
There was a problem hiding this comment.
eas deploy:promote works, but I think eas worker:promote has been added, I'm getting a Error: command worker:promote not found.
As discussed, the command itself is called |
c73d90f to
a1611f1
Compare
|
✅ Thank you for adding the changelog entry! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2563 +/- ##
==========================================
- Coverage 52.19% 52.16% -0.02%
==========================================
Files 557 559 +2
Lines 21035 21062 +27
Branches 4304 4308 +4
==========================================
+ Hits 10977 10985 +8
- Misses 9187 9203 +16
- Partials 871 874 +3 ☔ View full report in Codecov by Sentry. |
|
I added a fix for the typing issue from the updates test, mostly to get this PR mergable. No idea what's going on there, but it seems that the I'll go ahead and merge this PR, but do ping me if the fix I added is incorrect. |
Why
This adds
worker:alias --prodand supportsworker:promote --prod(we can document either one) to promote existing deployments to production. We could split the command later, if people ask for this use case a lot.How
--prod(uction)toworker:aliasworker:promotealias ofworker:aliassrc/worker/utils/logs.tsworkerandworker:aliasserverlesstohostingTest Plan
$ eas worker$ eas worker:alias --id <deployment> --alias test-alias$ eas worker:alias --id <deployment> --alias test-alias --json --non-interactive | jq$ eas worker:promote --prod --id <deployment> --json --non-interactive | jq