Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump @expo/apple-utils to improve error handling and input validation and change auth headers #2745

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Dec 6, 2024

Why

It probably won't fix #2698 but it contains some valid updates.

How

Bump @expo/apple-utils to improve error handling and input validation and slightly change auth headers

Test Plan

Tested manually

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Dec 6, 2024

Size Change: +963 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +963 B (0%)

compressed-size-action

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.51%. Comparing base (f34487c) to head (e28c4ff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2745   +/-   ##
=======================================
  Coverage   52.51%   52.51%           
=======================================
  Files         583      583           
  Lines       22556    22556           
  Branches     4438     4438           
=======================================
  Hits        11842    11842           
  Misses      10679    10679           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic marked this pull request as ready for review December 6, 2024 11:21
Copy link

github-actions bot commented Dec 6, 2024

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Dec 6, 2024

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit 44af16e into main Dec 6, 2024
11 checks passed
@szdziedzic szdziedzic deleted the 12-06-bump_expo_apple-utils_to_improve_error_handling_and_input_validation_and_change_auth_headers branch December 6, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple Authentication error
2 participants