[ENG-14328] Pass environment to PublishMutation.publishUpdateGroupAsync#2757
Merged
khamilowicz merged 1 commit intomainfrom Dec 13, 2024
Conversation
|
Size Change: -84 B (0%) Total Size: 53.4 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2757 +/- ##
==========================================
+ Coverage 52.49% 52.51% +0.03%
==========================================
Files 583 583
Lines 22556 22577 +21
Branches 4438 4448 +10
==========================================
+ Hits 11839 11855 +16
- Misses 10682 10687 +5
Partials 35 35 ☔ View full report in Codecov by Sentry. |
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
|
Subscribed to pull request
Generated by CodeMention |
wschurman
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ENG-14328: store
environmentinfo on update entityPass
environmenttoPublishMutation.publishUpdateGroupAsyncto store in the db.Waits for changes on the
www. https://github.com/expo/universe/pull/17921