Skip to content

[ENG-14328] Pass environment to PublishMutation.publishUpdateGroupAsync#2757

Merged
khamilowicz merged 1 commit intomainfrom
piotrekszeremeta/eng-14328-store-environment-info-on-update-entity
Dec 13, 2024
Merged

[ENG-14328] Pass environment to PublishMutation.publishUpdateGroupAsync#2757
khamilowicz merged 1 commit intomainfrom
piotrekszeremeta/eng-14328-store-environment-info-on-update-entity

Conversation

@khamilowicz
Copy link
Copy Markdown
Contributor

@khamilowicz khamilowicz commented Dec 10, 2024

Why

ENG-14328: store environment info on update entity

Pass environment to PublishMutation.publishUpdateGroupAsync to store in the db.

Waits for changes on the www. https://github.com/expo/universe/pull/17921

@linear
Copy link
Copy Markdown

linear Bot commented Dec 10, 2024

@github-actions
Copy link
Copy Markdown

Size Change: -84 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -84 B (0%)

compressed-size-action

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.51%. Comparing base (97fe2d6) to head (93df05d).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2757      +/-   ##
==========================================
+ Coverage   52.49%   52.51%   +0.03%     
==========================================
  Files         583      583              
  Lines       22556    22577      +21     
  Branches     4438     4448      +10     
==========================================
+ Hits        11839    11855      +16     
- Misses      10682    10687       +5     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khamilowicz khamilowicz added the no changelog PR that doesn't require a changelog entry label Dec 12, 2024
@github-actions
Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@khamilowicz khamilowicz marked this pull request as ready for review December 12, 2024 10:31
@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @sjchmiela, @radoslawkrzemien
packages/eas-cli/src/commands/update/** @wschurman, @quinlanj

Generated by CodeMention

@khamilowicz khamilowicz merged commit 1c964d2 into main Dec 13, 2024
@khamilowicz khamilowicz deleted the piotrekszeremeta/eng-14328-store-environment-info-on-update-entity branch December 13, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants