-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-14518 Add keystoreName field to build profile #2775
ENG-14518 Add keystoreName field to build profile #2775
Conversation
Subscribed to pull request
Generated by CodeMention |
Size Change: +270 B (0%) Total Size: 53.4 MB
|
6fc4152
to
03e3d77
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2775 +/- ##
=======================================
Coverage 52.52% 52.52%
=======================================
Files 583 583
Lines 22589 22589
Branches 4452 4452
=======================================
Hits 11862 11862
Misses 10692 10692
Partials 35 35 ☔ View full report in Codecov by Sentry. |
/changelog-entry new-feature "Allow selecting credentials for android builds" |
03e3d77
to
2cdaa18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will happen if I set keystoreName
field and I don't have such a keystore created? Will it be generated for me?
@szdziedzic yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing
Oh I think we should also update |
2cdaa18
to
ae4d902
Compare
✅ Thank you for adding the changelog entry! |
Why
ENG-14518: Add
keystoreName
field to build profile to allow selecting/creating named keystore to use for a buildAllow specifying keystore name of credentials to be used with a build.
How
keystoreName
to eas.json schemaname
option toAndroidCredentialsProvider
Test Plan
Added test, tested manually.
eas credentials
keystoreName
in build profile ineas.json
remote
credentialsSource