Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-14518 Add keystoreName field to build profile #2775

Conversation

khamilowicz
Copy link
Contributor

Why

ENG-14518: Add keystoreName field to build profile to allow selecting/creating named keystore to use for a build

Allow specifying keystore name of credentials to be used with a build.

How

  • Added keystoreName to eas.json schema
  • Pass name option to AndroidCredentialsProvider

Test Plan

Added test, tested manually.

  1. Create a new android credentials with eas credentials
  2. Specify keystoreName in build profile in eas.json
  3. Ensure that it works only for android builds
  4. Ensure it works only for remote credentialsSource
  5. Ensure that the correct credentials are used
image image

Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Dec 17, 2024

Size Change: +270 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +270 B (0%)

compressed-size-action

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-14518-add-keystorename-field-to-build-profile-to-allow branch from 6fc4152 to 03e3d77 Compare December 19, 2024 16:08
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.52%. Comparing base (d1af9e3) to head (ae4d902).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../credentials/android/AndroidCredentialsProvider.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2775   +/-   ##
=======================================
  Coverage   52.52%   52.52%           
=======================================
  Files         583      583           
  Lines       22589    22589           
  Branches     4452     4452           
=======================================
  Hits        11862    11862           
  Misses      10692    10692           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khamilowicz
Copy link
Contributor Author

/changelog-entry new-feature "Allow selecting credentials for android builds"

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-14518-add-keystorename-field-to-build-profile-to-allow branch from 03e3d77 to 2cdaa18 Compare December 20, 2024 11:39
Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen if I set keystoreName field and I don't have such a keystore created? Will it be generated for me?

@khamilowicz
Copy link
Contributor Author

@szdziedzic yes
image

Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

@szdziedzic
Copy link
Member

Oh I think we should also update eas.schema.json and eas.json docs on docs.expo.dev

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-14518-add-keystorename-field-to-build-profile-to-allow branch from 2cdaa18 to ae4d902 Compare January 7, 2025 10:20
Copy link

github-actions bot commented Jan 7, 2025

✅ Thank you for adding the changelog entry!

@khamilowicz khamilowicz merged commit f05d6ca into main Jan 7, 2025
10 checks passed
@khamilowicz khamilowicz deleted the piotrekszeremeta/eng-14518-add-keystorename-field-to-build-profile-to-allow branch January 7, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants