[eas-cli] Silence all non-command output in non-interactive mode of eas env:exec

[wschurman]

Why

When using this programmatically to run a command, env:exec shouldn't modify the stdout of the sub-command. This makes it possible to run a JSON command, for example.

Concretely, this came up in https://github.com/expo/expo-github-action/pull/316/files#diff-9a4c8863ad4d04f246a265d420c404b948ffcd8902e7de5312c9205cd034fa2eR226 where we are trying to run npx expo-updates fingerprint:generate which outputs JSON.

How

One solution (this solution) is to slightly overload the non-interactive flag to also silence all non-command output. Alternatively we could add a separate flag.

I chose to overload the existing flag since I couldn't think of a reason that a non-interactive scenario would want the Log.log calls. That being said, I'm open to adding a separate flag like --raw or --passthrough or something else if overloading the flag is not desired.

Test Plan

Before:

$ neas env:exec preview "npx expo config --json --type public" --non-interactive
No environment variables with visibility "Plain text" and "Sensitive" found for the "preview" environment on EAS servers.

Running command: npx expo config --json --type public
[stdout] {"name":"pkfsa...

After:

$ neas env:exec preview "npx expo config --json --type public" --non-interactive
{"name":"pkfsa...

Other tests:

Does not print hello since subcommand had nonzero exit status:

$ neas env:exec preview "npx expo config --json --type publicd" --non-interactive && echo "hello"

Ensure output (no output) matches:

npx expo config --json --type publicd && echo "hello"

Prints hello after config (correct success exit status):

$ neas env:exec preview "npx expo config --json --type public" --non-interactive && echo "hello"
{"name":"pkfsa...
hello

Ensure output (no output) matches:

npx expo config --json --type public && echo "hello"

[wschurman]

• [eas-cli] Silence all non-command output in non-interactive mode of eas env:exec #2800 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Size Change: -1.63 kB (0%)

Total Size: 53.4 MB

Filename	Size	Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz	53.4 MB	-1.63 kB (0%)

_{compressed-size-action}

[github-actions]

Subscribed to pull request

File Patterns	Mentions
**/*	@szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 52.49%. Comparing base (f05d6ca) to head (163c212).

Files with missing lines	Patch %	Lines
packages/eas-cli/src/commands/env/exec.ts	0.00%	20 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2800      +/-   ##
==========================================
- Coverage   52.52%   52.49%   -0.03%     
==========================================
  Files         583      583              
  Lines       22589    22602      +13     
  Branches     4452     4458       +6     
==========================================
  Hits        11862    11862              
- Misses      10692    10705      +13     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[szdziedzic]

Looks like a good idea overall, thanks 🙏

I have one suggestion:

[github-actions]

✅ Thank you for adding the changelog entry!

[szdziedzic]

Looks reasonable to me, thanks! 🙏