Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-14644][eas-cli] make "No remote versions are configured" message green instead of yellow #2805

Merged

Conversation

szdziedzic
Copy link
Member

Why

https://linear.app/expo/issue/ENG-14644/make-no-remote-versions-are-configured-message-green-instead-of-yellow

How

make "No remote versions are configured" message green instead of yellow

Test Plan

Tests

Copy link

linear bot commented Jan 8, 2025

Copy link

github-actions bot commented Jan 8, 2025

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Jan 8, 2025

Size Change: +820 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +820 B (0%)

compressed-size-action

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.48%. Comparing base (86c8ac0) to head (140e291).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/build/android/version.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/build/ios/version.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2805   +/-   ##
=======================================
  Coverage   52.48%   52.48%           
=======================================
  Files         583      583           
  Lines       22603    22603           
  Branches     4461     4461           
=======================================
  Hits        11860    11860           
  Misses      10708    10708           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic force-pushed the @szdziedzic/make-no-remote-versions-configured-message-green branch from 89e4975 to 140e291 Compare January 10, 2025 10:05
Copy link

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit 6461a78 into main Jan 10, 2025
10 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/make-no-remote-versions-configured-message-green branch January 10, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants