Skip to content

fix: convert privacy policy rule definition to functions #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wschurman wants to merge 1 commit into from
Closed

fix: convert privacy policy rule definition to functions #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 37 additions & 8 deletions packages/entity/src/EntityPrivacyPolicy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,34 +98,63 @@ export default abstract class EntityPrivacyPolicy<
TEntity extends ReadonlyEntity<TFields, TID, TViewerContext, TSelectedFields>,
TSelectedFields extends keyof TFields = keyof TFields
> {
protected readonly createRules: readonly PrivacyPolicyRule<
protected abstract getCreateRules?(): readonly PrivacyPolicyRule<
TFields,
TID,
TViewerContext,
TEntity,
TSelectedFields
>[] = [];
protected readonly readRules: readonly PrivacyPolicyRule<
>[];
protected abstract getReadRules?(): readonly PrivacyPolicyRule<
TFields,
TID,
TViewerContext,
TEntity,
TSelectedFields
>[] = [];
protected readonly updateRules: readonly PrivacyPolicyRule<
>[];
protected abstract getUpdateRules?(): readonly PrivacyPolicyRule<
TFields,
TID,
TViewerContext,
TEntity,
TSelectedFields
>[] = [];
protected readonly deleteRules: readonly PrivacyPolicyRule<
>[];
protected abstract getDeleteRules?(): readonly PrivacyPolicyRule<
TFields,
TID,
TViewerContext,
TEntity,
TSelectedFields
>[] = [];
>[];

private createRules: readonly PrivacyPolicyRule<
TFields,
TID,
TViewerContext,
TEntity,
TSelectedFields
>[] = this.getCreateRules ? this.getCreateRules() : [];
private readRules: readonly PrivacyPolicyRule<
TFields,
TID,
TViewerContext,
TEntity,
TSelectedFields
>[] = this.getReadRules ? this.getReadRules() : [];
private updateRules: readonly PrivacyPolicyRule<
TFields,
TID,
TViewerContext,
TEntity,
TSelectedFields
>[] = this.getUpdateRules ? this.getUpdateRules() : [];
private deleteRules: readonly PrivacyPolicyRule<
TFields,
TID,
TViewerContext,
TEntity,
TSelectedFields
>[] = this.getDeleteRules ? this.getDeleteRules() : [];

/**
* Get the privacy policy evaluation mode and deny handler for this policy.
Expand Down
52 changes: 40 additions & 12 deletions packages/entity/src/__tests__/cases/TwoEntitySameTableDisjointRows-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import EntityPrivacyPolicy from '../../EntityPrivacyPolicy';
import ViewerContext from '../../ViewerContext';
import { successfulResults, failedResults } from '../../entityUtils';
import AlwaysAllowPrivacyPolicyRule from '../../rules/AlwaysAllowPrivacyPolicyRule';
import PrivacyPolicyRule from '../../rules/PrivacyPolicyRule';
import { createUnitTestEntityCompanionProvider } from '../../utils/testing/createUnitTestEntityCompanionProvider';

describe('Two entities backed by the same table', () => {
Expand Down Expand Up @@ -107,18 +108,45 @@ const testEntityConfiguration = new EntityConfiguration<TestFields>({
});

class TestEntityPrivacyPolicy extends EntityPrivacyPolicy<any, string, ViewerContext, any, any> {
protected override readonly readRules = [
new AlwaysAllowPrivacyPolicyRule<any, string, ViewerContext, any, any>(),
];
protected override readonly createRules = [
new AlwaysAllowPrivacyPolicyRule<any, string, ViewerContext, any, any>(),
];
protected override readonly updateRules = [
new AlwaysAllowPrivacyPolicyRule<any, string, ViewerContext, any, any>(),
];
protected override readonly deleteRules = [
new AlwaysAllowPrivacyPolicyRule<any, string, ViewerContext, any, any>(),
];
protected override getReadRules(): readonly PrivacyPolicyRule<
any,
string,
ViewerContext,
any,
any
>[] {
return [new AlwaysAllowPrivacyPolicyRule<any, string, ViewerContext, any, any>()];
}

protected override getCreateRules(): readonly PrivacyPolicyRule<
any,
string,
ViewerContext,
any,
any
>[] {
return [new AlwaysAllowPrivacyPolicyRule<any, string, ViewerContext, any, any>()];
}

protected override getUpdateRules(): readonly PrivacyPolicyRule<
any,
string,
ViewerContext,
any,
any
>[] {
return [new AlwaysAllowPrivacyPolicyRule<any, string, ViewerContext, any, any>()];
}

protected override getDeleteRules(): readonly PrivacyPolicyRule<
any,
string,
ViewerContext,
any,
any
>[] {
return [new AlwaysAllowPrivacyPolicyRule<any, string, ViewerContext, any, any>()];
}
}

class OneTestEntity extends Entity<TestFields, string, ViewerContext, OneTestFields> {
Expand Down