[ci] Upgrade codemention and change comment preamble and epilogue #31958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @wschurman and the rest of your teammates on |
Closed
|
tsapeta
approved these changes
Oct 10, 2024
Kudo
approved these changes
Oct 10, 2024
wschurman
deleted the
@wschurman/10-09-_ci_upgrade_codemention_and_change_comment_preamble_and_epilogue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This upgrades codemention to include the changes I made upstream to help with display issues on iOS notifications.
The changes do two things:
Closes ENG-13710.
How
Set preamble and epilogue to more helpful things. Open to suggestions for these fields.
tobyhs/codemention#15
tobyhs/codemention#18
Test Plan
Before:
Create a test PR on top of this to see output (see stacked PR).
Results:
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).