Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runtime] Resolve peer dependency issue with react-native-reanimated 2.8 #292

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danstepanov
Copy link
Contributor

@danstepanov danstepanov commented May 18, 2022

Why

react-native-reanimated was throwing an issue due to a recent upgrade to 2.8, particularly this issue software-mansion/react-native-reanimated#3111

Snack recreating issue (will no longer be relevant once this is merged)

How

Shoutout to @nandorojo and @andreialecu for help in getting this across the finish line

Test Plan

  1. Delete node_modules and clear all caches in snack-sdk, snack-content, and runtime
  2. Delete .expo in runtime
  3. Set isLocalWebPreview = true
  4. Run yarn && yarn build && yarn start in root
  5. Run yarn && yarn web in runtime
  6. Navigate to https://snack.expo.test in your browser
  7. Copy and paste the code from the above Snack's App.js to the App.js in your https://snack.expo.test
  8. When prompted, add moti as a dependency
  9. The error should no longer appear, you should see the project load properly

@linear
Copy link

linear bot commented May 18, 2022

ENG-4602 Upgrade to SDK 45

When the SDK 45 Beta is released (approx 20th of April), we should start upgrading Snack to support SDK 45.

The documentation to upgrade the Expo SDK on Snack can be found here: https://github.com/expo/snack/blob/main/docs/expo-sdk-upgrade.md

@danstepanov danstepanov changed the title test commit Resolve peer dependency issue with react-native-reanimated 2.8 May 19, 2022
@danstepanov danstepanov force-pushed the @danstepanov/eng-4602-sdk-45-dependencies branch from 69f8b58 to 478928e Compare May 19, 2022 00:25
@danstepanov danstepanov changed the title Resolve peer dependency issue with react-native-reanimated 2.8 [runtime] Resolve peer dependency issue with react-native-reanimated 2.8 May 19, 2022
@danstepanov danstepanov marked this pull request as ready for review May 19, 2022 00:26
@danstepanov danstepanov requested a review from byCedric as a code owner May 19, 2022 00:26
@byCedric
Copy link
Member

Before we can merge this, I'm checking with the SDK team why react-native-gesture-handler was not upgraded during the SDK 45 cycle. We still use ~2.2.1 in Expo Go, adding this will likely cause the native layer to be out of sync.

@himrocks33
Copy link

This does fix the issue on web but it introduces a new issue on android:
["RNGestureHandlerRootView" was not found in the UIManager]
I attempted suggested fixes here:
https://stackoverflow.com/questions/71396210/rngesturehandlerrootview-was-not-found-in-the-uimanager
None of which seem to make a difference. Only way to get android to work is to downgrade RN Gesture Handler.

- Upgrade react-native-gesture-handler to ~2.4.2 for snack-sdk and runtime
@danstepanov danstepanov force-pushed the @danstepanov/eng-4602-sdk-45-dependencies branch from 478928e to 1840912 Compare May 19, 2022 21:21
@byCedric byCedric marked this pull request as draft May 24, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants