Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump react-native-paper to 5.12.5 #606

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flexbox
Copy link

@flexbox flexbox commented Sep 16, 2024

Why

as a user,
I can use the last version of react-native-paper,
so that i don't blame snack.expo.dev to be "broken"

How

  • bump react-native-paper

Test Plan

  1. open https://snack.expo.dev/
  2. open Text https://callstack.github.io/react-native-paper/docs/components/Text/
  3. Paste
    <Text variant="displayLarge">Display Large</Text>
    <Text variant="displayMedium">Display Medium</Text>
    <Text variant="displaySmall">Display small</Text>

    <Text variant="headlineLarge">Headline Large</Text>
    <Text variant="headlineMedium">Headline Medium</Text>
    <Text variant="headlineSmall">Headline Small</Text>

    <Text variant="titleLarge">Title Large</Text>
    <Text variant="titleMedium">Title Medium</Text>
    <Text variant="titleSmall">Title Small</Text>

    <Text variant="bodyLarge">Body Large</Text>
    <Text variant="bodyMedium">Body Medium</Text>
    <Text variant="bodySmall">Body Small</Text>

    <Text variant="labelLarge">Label Large</Text>
    <Text variant="labelMedium">Label Medium</Text>
    <Text variant="labelSmall">Label Small</Text>

Actually
CleanShot 2024-09-16 at 11 59 05

Expected
CleanShot 2024-09-16 at 11 59 33

From my machine

snack-sdk:test: Ran all test suites.

 Tasks:    10 successful, 10 total
Cached:    8 cached, 10 total
  Time:    4.593s

CleanShot 2024-09-16 at 12 08 18

@flexbox flexbox requested a review from byCedric as a code owner September 16, 2024 10:01
@flexbox flexbox changed the title chore(deps): bump react-native-paper to 5.12.5 chore(deps): bump react-native-paper to 5.12.5 Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant