Add policy to align engines fields with ci #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
UlisesGascon
commented
Oct 22, 2024
•
UlisesGascon
commented
- closes: Discussion: Using engines in the package.json #286
- related: Re-thinking the discussion process #285
This was referenced Oct 22, 2024
Merged
bjohansebas
approved these changes
Oct 22, 2024
blakeembrey
approved these changes
Oct 22, 2024
UlisesGascon
commented
Oct 23, 2024
|
|
||
| **What will be done?** | ||
| - Update the `engines` field in `package.json` for each package to reflect the minimum Node.js version supported by the corresponding CI configuration. | ||
|
|
There was a problem hiding this comment.
Suggested change
| - Include the `engines` fields in all the projects, so it will clarify what is supported for the final user | |
suggested by @ctcpip on the last TC Meeting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.