Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove redundant function name from app.disable #6125

Closed

Conversation

Ayoub-Mabrouk
Copy link
Contributor

The function name disable was unnecessary since it's already clear from the app.disable property assignment.
Removing it simplifies the code, improves readability, and follows best practices for concise function expressions.

The function name disable was unnecessary since it's already clear from the �pp.disable property assignment. Removing it simplifies the code, improves readability, and follows best practices for concise function expressions.
@bjohansebas
Copy link
Member

@Ayoub-Mabrouk Thanks, but this is a style change that doesn't bring any improvement.

@bjohansebas bjohansebas closed this Dec 5, 2024
@wesleytodd
Copy link
Member

Additionally for anyone looking at this in the future. Function names are critical for production debugging in many cases. Please name all your functions and preserve names where they already exist. The only exception is for implementation detail functions within other named functions. For example, a callback passed to map is alright not to name if something else in the call stack can be used to help identify it in stack traces, logs, and flamegraphs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants