Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update obsolete code of index.js of example "online" #6153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leeli0
Copy link

@leeli0 leeli0 commented Nov 7, 2024

online package is obsolete, doesn't work with the latest redis package any more. The way to connect to redis server also is also need to be changed.

@wesleytodd
Copy link
Member

Honestly I think I am of the opinion that we should delete all examples that rely on external packages. This is too much of a risk for us to be promoting if the express project doesn't own the package. This is a great target for a malicious attacker. I am going to bring this one up with the rest of the @expressjs/express-tc to get a feel for folks opinions, but my vote is we remove this example entirely.

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a blocking review until we can decide on this.

@ctcpip
Copy link
Member

ctcpip commented Nov 15, 2024

technically, online is a tjholowaychuk package, so... 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants