Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cookie): remove cookie-signature dependency and use the native crypto module to sign cookie #6175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bhavya3024
Copy link
Contributor

@bhavya3024 bhavya3024 commented Nov 13, 2024

cookie-signature dependency is not required since it itself uses the crypto module to sign cookies itself.
You can check here: https://github.com/tj/node-cookie-signature/blob/master/index.js

@bhavya3024 bhavya3024 changed the title refactor(cookie): remove cookie-parser dependency and use the native crypto module to sign cookie refactor(cookie): remove cookie-signature dependency and use the native crypto module to sign cookie Nov 13, 2024
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern with this is if the ecosystem of middleware is using cookie-signature to sign their own cookies that can then be read by express, this means we can no longer rely on it all working the same as we update in the future. I am going to request changes for now just to ensure we address that before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants