Refactor res.send() into helper functions #6654
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainability Signed-off-by: Nitin <[email protected]>
bjohansebas
requested changes
Aug 4, 2025
mlaopane
reviewed
Aug 25, 2025
Comment on lines
+134
to
+135
| if (!this.get('Content-Type')) this.type('html'); | ||
| encoding = 'utf8'; |
There was a problem hiding this comment.
Using curly braces would make it more consistent and readable.
Comment on lines
+136
to
+137
| } else if (typeof chunk === 'boolean' || typeof chunk === 'number' || chunk === null) { | ||
| chunk = chunk === null ? '' : chunk; |
There was a problem hiding this comment.
It would make sense to split the null case from the boolean | number case to avoid using a ternary.
| const etagFn = app.get('etag fn'); | ||
| const shouldGenerateETag = !res.get('ETag') && typeof etagFn === 'function'; | ||
|
|
||
| if (chunk === undefined) return chunk; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored
res.send()inresponse.jsto improve readability and maintainability. Broke up the large method into smaller helper functions:prepareChunksetETagHeaderstripBodyIfNotAllowedBehavior is preserved 100%. This helps future contributors understand and modify
res.send()more easily.