-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
47 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
# Pull Request Guidelines | ||
|
||
Our guidelines for submitting a pull request. | ||
|
||
## Before submitting a Pull Request, please make sure you have verified the following: | ||
|
||
- [ ] The commit message follows our guidelines: | ||
- A good commit message should be two things: meaningful and concise. It should not contain every single detail, describing each changed line—we can see all the changes in Git—but, at the same time, it should say enough to avoid ambiguity. | ||
- We use Microverse's commit message convention | ||
- The convention stablish that a commit message has to be in the present tense, imperative and lowercase. | ||
- Example: `fix typo in README.md` | ||
- [ ] Tests for the changes have been added (for bug fixes / features) | ||
- [ ] Docs have been added / updated (for bug fixes / features) | ||
|
||
## PR Type | ||
|
||
What kind of change does this PR introduce? | ||
|
||
<!-- Please check the one that applies to this PR using "x". --> | ||
- [ ] Bugfix | ||
- [ ] Feature | ||
- [ ] Code style update (formatting, local variables) | ||
- [ ] Refactoring (no functional changes, no api changes) | ||
- [ ] Build related changes | ||
- [ ] CI related changes | ||
- [ ] Other... Please describe: | ||
|
||
## What is the current behavior? | ||
|
||
Please describe the current behavior that you are modifying, or link to a relevant issue. | ||
|
||
Issue Number: N/A | ||
|
||
## What is the new behavior? | ||
|
||
Describe the new behavior or link to a relevant issue. | ||
|
||
## Does this PR introduce a breaking change? | ||
|
||
- [ ] Yes | ||
- [ ] No | ||
|
||
If this PR contains a breaking change, please describe the impact and migration path for existing applications below. | ||
|
||
## Other information | ||
|
||
Any other information that is important to this PR. |