Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix controllerPath on addControllerToModule #13

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Fix controllerPath on addControllerToModule #13

merged 2 commits into from
Aug 2, 2023

Conversation

eryk-vieira
Copy link
Contributor

Pull Request Guidelines

Our guidelines for submitting a pull request.

Before submitting a Pull Request, please make sure you have verified the following:

  • The commit message follows our guidelines:
    • A good commit message should be two things: meaningful and concise. It should not contain every single detail, describing each changed line—we can see all the changes in Git—but, at the same time, it should say enough to avoid ambiguity.
    • We use Microverse's commit message convention
    • The convention stablish that a commit message has to be in the present tense, imperative and lowercase.
    • Example: fix typo in README.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ x] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: N/A

What is the new behavior?

Describe the new behavior or link to a relevant issue.

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications below.

Other information

Any other information that is important to this PR.

@ghost
Copy link

ghost commented Aug 2, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@eryk-vieira eryk-vieira changed the title Fixed controllerPath on addControllerToModule Fix controllerPath on addControllerToModule Aug 2, 2023
@eryk-vieira
Copy link
Contributor Author

This PR is related to this issue #12

Copy link
Contributor

@Daniel-Boll Daniel-Boll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsaz rsaz added the bug Something isn't working label Aug 2, 2023
@rsaz rsaz self-assigned this Aug 2, 2023
Copy link
Member

@rsaz rsaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eryk-vieira in order to better test and validate your proposed changes can you let us know:

  • which project template were you using? opinionated or non-opinionated?
  • what package manager did you use?
  • complete command line used to generate the controller? ex: expressots g controller

@eryk-vieira
Copy link
Contributor Author

Hey! @rsaz

1 - Opinionated template
2 - NPM as package menager
3 - For example:

The opinionated template creates a user usecase.
By testing the cli tool i tried to generate a new controller so i ran expressots g controller user/something/

Running the command creates the new controller inside the user usecase normally. (As expected)
but the generated import at the user.module.ts is generated wrong as i reported at the issue #12

@rsaz rsaz self-requested a review August 2, 2023 23:43
@rsaz rsaz merged commit 2aaab9e into expressots:main Aug 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants