-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix controllerPath on addControllerToModule #13
Conversation
This PR is related to this issue #12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @eryk-vieira in order to better test and validate your proposed changes can you let us know:
- which project template were you using? opinionated or non-opinionated?
- what package manager did you use?
- complete command line used to generate the controller? ex: expressots g controller
Hey! @rsaz 1 - Opinionated template The opinionated template creates a user usecase. Running the command creates the new controller inside the user usecase normally. (As expected) |
Pull Request Guidelines
Our guidelines for submitting a pull request.
Before submitting a Pull Request, please make sure you have verified the following:
fix typo in README.md
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Please describe the current behavior that you are modifying, or link to a relevant issue.
Issue Number: N/A
What is the new behavior?
Describe the new behavior or link to a relevant issue.
Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the impact and migration path for existing applications below.
Other information
Any other information that is important to this PR.