Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(createProject): add types and remove useless projectForm arg… #17

Merged
merged 4 commits into from
Jul 31, 2024
Merged

refactor(createProject): add types and remove useless projectForm arg… #17

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a8d7eb
refactor(createProject): add types and remove useless projectForm arg…
joaoneto Aug 21, 2023
37d04eb
remove unused const
joaoneto Aug 24, 2023
2bad261
Merge remote-tracking branch 'origin/main' into refact/create-project…
rsaz Jul 31, 2024
6d1da80
refactor: update 'new' cmd removing unnecessary options
rsaz Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
42 changes: 17 additions & 25 deletions src/new/form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,30 +91,22 @@ const enum PackageManager {
bun = "bun",
}

const projectForm = async (projectName: string, args: any[]): Promise<void> => {
let answer: any;
const projName: string = projectName;
let packageManager: PackageManager | undefined;
let template: keyof typeof Template | undefined;
let directory: string | undefined;

// Resolving the argument order problem
for (const arg of args) {
if (args.length >= 3) {
if (
arg === "npm" ||
arg === "yarn" ||
arg === "pnpm" ||
arg === "bun"
) {
packageManager = arg as PackageManager;
} else if (arg === "non-opinionated" || arg === "opinionated") {
template = arg as keyof typeof Template;
} else {
directory = arg;
}
}
}
type TemplateKeys = keyof typeof Template;

type ProjectFormArgs = [
PackageManager,
TemplateKeys,
string,
];

const projectForm = async (projectName: string, args: ProjectFormArgs): Promise<void> => {
let answer: {
name: string;
packageManager: string;
template: Template;
confirm: boolean;
};
const [packageManager, template, directory] = args;

if (packageManager && template) {
answer = {
Expand Down Expand Up @@ -230,7 +222,7 @@ const projectForm = async (projectName: string, args: any[]): Promise<void> => {

changePackageName({
directory: answer.name,
name: projName,
name: projectName,
});

progressBar.update(100);
Expand Down