-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/experimetal transpile with swc #18
Open
joaoneto
wants to merge
5
commits into
expressots:main
Choose a base branch
from
joaoneto:feat/experimetal-transpile-with-swc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/experimetal transpile with swc #18
joaoneto
wants to merge
5
commits into
expressots:main
from
joaoneto:feat/experimetal-transpile-with-swc
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel-Boll
reviewed
Aug 21, 2023
joaoneto
force-pushed
the
feat/experimetal-transpile-with-swc
branch
2 times, most recently
from
August 23, 2023 02:57
5198fcd
to
c37ca63
Compare
Daniel-Boll
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work, loved the refactor of the templates-list.ts
, well done!
As soon as @juliano-soares approve it, @rsaz may test it on Windows and merge. |
…swc transpile system
…or interactive choices - add template types and enum - add conditional template selection - fix src/new/cli.ts bad eol
joaoneto
force-pushed
the
feat/experimetal-transpile-with-swc
branch
from
October 9, 2023 20:10
2b45438
to
b86b598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Guidelines
Our guidelines for submitting a pull request.
Before submitting a Pull Request, please make sure you have verified the following:
fix typo in README.md
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Please describe the current behavior that you are modifying, or link to a relevant issue.
Issue Number: N/A
What is the new behavior?
Describe the new behavior or link to a relevant issue.
Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the impact and migration path for existing applications below.
Other information
Added experimental flag for templates (see: #17)
An interactive stdout example:
Added cli commands:
This pull request moves the dependencies that used to be in the templates to the CLI, making it essential for the build.
This change simplifies the installation and maintenance of the templates, as they no longer need to have the same dependencies as the CLI. It also allows the CLI to have more control over the build process and use different tools for different tasks.
The pull request adds new dependencies to the expressots-cli package.json file:
It also adds a new dev dependency:
The new dependencies can be removed from the templates.
The pull request also adds new commands to the expressots-cli bin file:
expressots dev
: usests-node-dev
to start the server and watch for changes in the./src
directory and reload, showing type errors.expressots dev --experimental
: usesnodemon
in conjunction withtsc
andeslint
respectively to start the server and watch for changes in the./src
directory and reload and in parallel validate the typing and code style, showing errors.expressots build
: usestsc
that look fortsconfig.build.json
to transpile a hole project in distexpressots build --experimental
: usesconcurrently
to start types, lint and build (with swc) in parallel, and if one of these tasks fail, the process exit code is an errorAny other information that is important to this PR.