Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/segregate op nop scaffold #36

Merged
merged 17 commits into from
Mar 29, 2024
Merged

Conversation

rsaz
Copy link
Member

@rsaz rsaz commented Mar 28, 2024

Pull Request Guidelines

Our guidelines for submitting a pull request.

Before submitting a Pull Request, please make sure you have verified the following:

  • A good commit message should be two things: meaningful and concise. It should not contain every single detail, describing each changed line—we can see all the changes in Git—but, at the same time, it should say enough to avoid ambiguity.
  • We use Microverse's commit message convention
  • The convention stablish that a commit message has to be in the present tense, imperative and lowercase.
  • Example: fix typo in README.md
  • The commit message follows our guidelines:
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.
N/A

Issue Number: N/A

What is the new behavior?

Describe the new behavior or link to a relevant issue.

Refactor the generation resource code for better maintainability and add in expressots.config the possibility to custom the scaffold resource names

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications below.

Other information

Any other information that is important to this PR.

@rsaz rsaz added the enhancement New feature or request label Mar 28, 2024
@rsaz rsaz self-assigned this Mar 28, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file can be removed

@rsaz rsaz merged commit dc0ac11 into main Mar 29, 2024
1 check passed
@rsaz rsaz deleted the feature/segregate-op-nop-scaffold branch March 29, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants