Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove inversify binding decorators @provide #48

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

rsaz
Copy link
Member

@rsaz rsaz commented Jul 4, 2024

Pull Request Guidelines

Our guidelines for submitting a pull request.

Before submitting your PR, please verify the following:

  • The commit message follows our guidelines:

    Make sure you prefix your commit message with the type of change you are making. Your commit message should look like this: type: description of the change.

    • Fixing a bug : fix: description of the change.
    • Adding a new feature : feat: description of the change.

See the options for the different types of changes you can make in the package.json file of your project.

Leave the options below unchecked if they are not applicable to your Pull Request.

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Test
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

If yes Please describe the impact and mitigation strategy for existing applications.

What was changed?

Please describe what you have changed in this PR.
Change the dependency of the templates to rely on @provide from @core and not more from inversify-binding-decorators

Other information

Any other information that is important to this PR.

@rsaz rsaz added the enhancement New feature or request label Jul 4, 2024
@rsaz rsaz self-assigned this Jul 4, 2024
@rsaz rsaz merged commit 8a7c9c0 into main Jul 4, 2024
2 checks passed
@rsaz rsaz deleted the feature/change-template-to-provider-core branch July 4, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant