Added font-weight support #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
27
to
29
| case "normal": return .regular | ||
| case "bold": return .bold | ||
| case "bolder": return .black |
There was a problem hiding this comment.
What's up with these spacings? 😄
There was a problem hiding this comment.
ocd? hahah I'm just a fan of lined-up code
There was a problem hiding this comment.
I mean any SwiftFormat/SwiftLint or similar tool would start freaking out here 😄
There was a problem hiding this comment.
alr I'll use conventions then
There was a problem hiding this comment.
@msrutek-paylocity I fixed the spacing using swift conventions 🖖
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added font-weight support #51 with a note for
lighterandbolderwhich are context related and must be fixed in a future patch (that's why we use a member function rather than an extension onFont.Weight).Fixed the exhaustive switch warning in
MBezierPathas well.