-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style issue with a behaviour association #279
Style issue with a behaviour association #279
Conversation
The code is hard to understand, could you try to refactor or renaming functions and variables please?, or some comments on the function to understand what exactly associated popups means |
Tried some comments and renames. It is a bit hard, but all about responsibility propagation. Context menu reports that it is open. UserApplication reports that, it has opened view. Bar calculates the opened views and block the hide methodology. One more unintended behaviour removed: Context menu on preview items and context menu on context menu (from master): Screen.Recording.2024-11-14.165511.mp4Bit hard to create a video, for something do not do something... :) |
renamed the class for consistence: 'associated-view-open' |
Additional minors, cause this is still open and the same category:
Finished the style rush for now... :) |
650ece4
to
67933a0
Compare
333c69a
to
d0f07de
Compare
|
d0f07de
to
12956df
Compare
Ok, this will be a bit hard, will make some video to understand it more clearly.
Issue: When you leave weg for a blink, it closes the weg bar in case of HideMode.Always & HideMode.On-Overlap
First: It is currently working.


Side note: because in default style, we have a glitch:
In this image it seems when you move to preview, it leaves the weg bar... but in the reality, the preview hops under your mouse:
If you have different style, it behaves as I described:
Screen.Recording.2024-11-14.113700.mp4
For this to remain open and correct logic to expand I got to wire in the associated pop-ups in the logic. This behaviour is gone with this.
For better style options I gave a possibility to style the opened item whose associatedPopup is opened.
class: 'opened-associated-view'
Hereby you can style like this (Mosue is on preview item / context menu):



Pre:
The "can" and "should" does not comes together; the styles I did not change for now.
Other change:

Closes the preview items in case of weg item context menu. This is mostly unintended I think: