refactor : refreshToken 인식 문제 해결 #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minjee2758
requested review from
Kimminu7,
NCookies,
chat26666,
pokerbearkr and
thezz9
Walkthrough토큰 리프레시 엔드포인트의 시큐리티 요구 사항 어노테이션이 "JWT_REFRESH"에서 "Authorization"으로 변경되었습니다. 또한, 리프레시 토큰을 추출하는 HTTP 헤더도 "JWT_REFRESH"에서 "Authorization"으로 변경되었습니다. 토큰 추출 로직은 동일하게 유지됩니다. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant AuthController
participant HttpServletRequest
Client->>AuthController: POST /refresh (Authorization: Bearer <refresh_token>)
AuthController->>HttpServletRequest: getHeader("Authorization")
AuthController->>AuthController: "Bearer " 접두사 제거 및 검증
AuthController-->>Client: 새 토큰 또는 오류 반환
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/java/org/ezcode/codetest/presentation/usermanagement/AuthController.java (1)
82-82: 디버그 로그를 제거하는 것을 고려해보세요.리프레시 토큰 정보를 로그로 출력하는 것은 보안상 위험할 수 있으며, PR 체크리스트에서도 불필요한 console.log 제거를 언급했습니다.
- log.info("Refresh token 추출 : {}", token);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/java/org/ezcode/codetest/presentation/usermanagement/AuthController.java(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
src/main/java/org/ezcode/codetest/presentation/usermanagement/AuthController.java (1)
Learnt from: NCookies
PR: ezcode-my/backend#17
File: src/main/java/org/ezcode/codetest/presentation/problemmanagement/ProblemAdminController.java:25-25
Timestamp: 2025-06-02T06:57:37.929Z
Learning: 이 프로젝트에서는 아직 Spring Security가 적용되지 않아서 @PreAuthorize 어노테이션이 주석 처리되어 있음. Spring Security 도입 전까지는 권한 검증 어노테이션들이 비활성화 상태임.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (2)
src/main/java/org/ezcode/codetest/presentation/usermanagement/AuthController.java (2)
73-73: Swagger 보안 요구사항 변경이 올바르게 적용되었습니다.
JWT_REFRESH에서Authorization으로 변경한 것은 표준 OAuth2/JWT 관례를 따르는 좋은 개선사항입니다.
78-78: 헤더 추출 로직이 Swagger 어노테이션과 일치하도록 올바르게 변경되었습니다.Authorization 헤더를 사용하는 것은 로그아웃 메서드(65-67라인)와 일관성을 유지하며 표준 관례를 따릅니다. 다만 기존 클라이언트에서
JWT_REFRESH헤더를 사용하고 있었다면 breaking change가 될 수 있으니 확인이 필요합니다.다음 스크립트를 실행하여 기존 클라이언트 코드에서
JWT_REFRESH헤더 사용을 확인해주세요:#!/bin/bash # 설명: JWT_REFRESH 헤더를 사용하는 클라이언트 코드가 있는지 확인 # 예상 결과: 클라이언트 코드에서 JWT_REFRESH 사용 여부 확인 # 테스트: 프로젝트 전체에서 JWT_REFRESH 사용 검색 rg -i "jwt_refresh" --type js --type ts --type java
NCookies
approved these changes
Jun 27, 2025
pokerbearkr
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
트러블 슈팅
해결해야 할 문제
코드 리뷰 전 확인 체크리스트
type :)Summary by CodeRabbit