-
Notifications
You must be signed in to change notification settings - Fork 3
Style/code review #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Style/code review #152
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,13 +8,20 @@ protected boolean isValidFormat(String content, boolean isCorrect) { | |
| if (content == null) | ||
| return false; | ||
|
|
||
| if (isCorrect) { | ||
| return content.contains("시간 복잡도:") && | ||
| content.contains("코드 총평:") && | ||
| content.contains("조금 더 개선할 수 있는 방안:"); | ||
| if (!isCorrect) { | ||
|
|
||
| boolean containsRequired = content.contains("**코드 총평**:") && | ||
| content.contains("**공부하면 좋은 키워드**:")&& | ||
| content.contains("**조금 더 개선할 수 있는 방안**:"); | ||
|
|
||
| boolean containsForbidden = content.contains("**시간 복잡도**:") || | ||
| content.toLowerCase().contains("**시간복잡도:**"); | ||
|
Comment on lines
+17
to
+18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion 금지 콘텐츠 검증 로직 개선 필요
다음과 같이 개선하는 것을 권장합니다: - boolean containsForbidden = content.contains("**시간 복잡도**:") ||
- content.toLowerCase().contains("**시간복잡도:**");
+ boolean containsForbidden = content.contains("**시간 복잡도**:") ||
+ content.toLowerCase().contains("시간복잡도") ||
+ content.toLowerCase().contains("시간 복잡도");🤖 Prompt for AI Agents |
||
|
|
||
| return containsRequired && !containsForbidden; | ||
| } | ||
|
|
||
| return content.contains("코드 총평:") && | ||
| content.contains("공부하면 좋은 키워드:"); | ||
| return content.contains("**시간 복잡도**:") && | ||
| content.contains("**코드 총평**:") && | ||
| content.contains("**조금 더 개선할 수 있는 방안**:"); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.