-
Notifications
You must be signed in to change notification settings - Fork 3
feat : 토론글 목록 조회 시 languageId 필드 추가 및 프론트 적용 #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
언어 ID 필드 추가가 올바르게 구현되었습니다.
discussion.language.id가 쿼리 프로젝션에 적절히 추가되었습니다.QDiscussionQueryResult생성자의 매개변수 순서도 올바릅니다.AI 요약에 따르면
groupBy절에도discussion.language.id가 추가되어야 한다고 언급되어 있는데, 현재 diff에서는 확인되지 않습니다. 다음 스크립트로groupBy절이 올바르게 업데이트되었는지 확인해주세요:🏁 Script executed:
Length of output: 72
다음 스크립트로
DiscussionQueryRepositoryImpl.java파일 내groupBy절에discussion.language.id가 포함되었는지 확인해 보겠습니다.🏁 Script executed:
Length of output: 685
언어 ID 필드 프로젝션은 올바르게 추가되었으나
groupBy절에도 반영이 필요합니다.src/main/java/org/ezcode/codetest/infrastructure/persistence/repository/community/discussion/DiscussionQueryRepositoryImpl.java두 번째 쿼리의
groupBy블록변경 전:
변경 제안:
.groupBy( discussion.id, + discussion.language.id, user.id, user.nickname, user.tier, user.profileImageUrl, // … )이렇게 하면 프로젝션에 추가한
discussion.language.id에 대해 그룹핑도 일관되게 처리됩니다.🤖 Prompt for AI Agents