Skip to content

fix : 회원 정보 수정 API Swagger 및 S3 이미지 삭제 버그 수정 #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NCookies merged 3 commits into from
Dec 15, 2025
Merged

fix : 회원 정보 수정 API Swagger 및 S3 이미지 삭제 버그 수정 #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ff250e
fix : swagger 설정 변경 및 내 정보 수정 API 테스트 동작하도록 수정
NCookies Dec 15, 2025
a04cd12
fix : 프로필 이미지 수정 시 더 이상 사용되지 않는 기존 이미지가 s3 버킷에서 삭제되지 않는 문제 수정
NCookies Dec 15, 2025
894dabe
fix : oldImageUrl이 빈 문자열("")일 때에도 정상적으로 예외 처리하도록 수정
NCookies Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/main/java/org/ezcode/codetest/application/usermanagement/user/service/UserService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import org.springframework.stereotype.Service;

import org.springframework.transaction.annotation.Transactional;
import org.springframework.util.StringUtils;
import org.springframework.web.multipart.MultipartFile;

import lombok.RequiredArgsConstructor;
Expand Down Expand Up @@ -106,10 +107,10 @@ public UserInfoResponse modifyUserInfo(AuthUser authUser, ModifyUserInfoRequest
String oldImageUrl = user.getProfileImageUrl();

user.modifyProfileImage(profileImageUrl);
if (oldImageUrl!=null) {
s3Uploader.delete(user.getProfileImageUrl(), "profile");
}

if (StringUtils.hasText(oldImageUrl)) {
s3Uploader.delete(oldImageUrl, "profile");
}
}

return UserInfoResponse.builder()
Expand Down
7 changes: 6 additions & 1 deletion src/main/java/org/ezcode/codetest/infrastructure/s3/S3Uploader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package org.ezcode.codetest.infrastructure.s3;

import java.io.IOException;
import java.net.URLDecoder;
import java.nio.charset.StandardCharsets;
import java.util.UUID;

import org.ezcode.codetest.infrastructure.s3.exception.S3Exception;
Expand Down Expand Up @@ -78,7 +80,10 @@ public void delete(String fileUrl, String dirName) {
if (dirName.equalsIgnoreCase("profile")) {
fileName = extractKeyFromProfileUrl(fileUrl);
}
amazonS3.deleteObject(bucket, fileName); // S3 내 이미지 객체 제거.

String decodedFileName = URLDecoder.decode(fileName, StandardCharsets.UTF_8);
amazonS3.deleteObject(bucket, decodedFileName); // S3 내 이미지 객체 제거.

log.info("S3에서 이미지 삭제 완료: {}", fileName);
} catch (Exception e) {
log.error("S3 이미지 삭제 실패: {}", fileUrl, e);
Expand Down
4 changes: 4 additions & 0 deletions src/main/java/org/ezcode/codetest/infrastructure/swagger/config/SwaggerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
@Server(
url = "https://api.ezcode.my", // ← 슬래시 없이 호스트만!
description = "Production server"
),
@Server(
url = "http://localhost:8080",
description = "Local Server"
)
},
info = @Info(title = "API 문서", version = "v1"),
Expand Down
17 changes: 14 additions & 3 deletions src/main/java/org/ezcode/codetest/presentation/usermanagement/UserController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
package org.ezcode.codetest.presentation.usermanagement;

import org.ezcode.codetest.application.submission.dto.response.language.LanguageResponse;
import org.ezcode.codetest.application.usermanagement.user.dto.request.ModifyUserInfoRequest;
import org.ezcode.codetest.application.usermanagement.user.dto.request.ChangeUserPasswordRequest;
import org.ezcode.codetest.application.usermanagement.user.dto.response.ChangeUserPasswordResponse;
import org.ezcode.codetest.application.usermanagement.user.dto.response.GrantAdminRoleResponse;
import org.ezcode.codetest.application.usermanagement.user.dto.response.UserDailySolvedHistoryResponse;
import org.ezcode.codetest.application.usermanagement.user.dto.response.UserInfoResponse;
import org.ezcode.codetest.application.usermanagement.user.dto.response.UserProfileImageResponse;
Expand All @@ -26,6 +24,9 @@
import org.springframework.web.multipart.MultipartFile;

import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.Parameter;
import io.swagger.v3.oas.annotations.media.Content;
import io.swagger.v3.oas.annotations.media.Encoding;
import io.swagger.v3.oas.annotations.tags.Tag;
import jakarta.validation.Valid;
import lombok.RequiredArgsConstructor;
Expand All @@ -46,7 +47,17 @@ public ResponseEntity<UserInfoResponse> getUserInfo(@AuthenticationPrincipal Aut
return ResponseEntity.status(HttpStatus.OK).body(userService.getUserInfo(authUser));
}

@Operation(summary = "내 정보 수정", description = "닉네임, 블로그, 깃허브, 소개 등 개인 정보를 추가하거나 수정합니다.")
@Operation(
summary = "내 정보 수정",
description = "닉네임, 블로그, 깃허브, 소개 등 개인 정보를 추가하거나 수정합니다.",
// ▼ 이 부분이 핵심입니다. Swagger에게 'request' 파트의 Content-Type을 강제합니다.
requestBody = @io.swagger.v3.oas.annotations.parameters.RequestBody(
content = @Content(
mediaType = MediaType.MULTIPART_FORM_DATA_VALUE,
encoding = @Encoding(name = "request", contentType = MediaType.APPLICATION_JSON_VALUE)
)
)
)
@PutMapping(value = "/users", consumes = MediaType.MULTIPART_FORM_DATA_VALUE)
public ResponseEntity<UserInfoResponse> modifyUserInfo(
@AuthenticationPrincipal AuthUser authUser,
Expand Down