Skip to content

feat : 신고 기능 개발 #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pokerbearkr merged 3 commits into from
Jun 22, 2025
Merged

feat : 신고 기능 개발 #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f28724
feat : 신고 기능 개발
pokerbearkr Jun 21, 2025
0297224
fix : 오타 수정
pokerbearkr Jun 21, 2025
01bcacb
refactor : 신고 상태값 예외 처리
pokerbearkr Jun 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/main/java/org/ezcode/codetest/application/report/dto/ReportChangeResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package org.ezcode.codetest.application.report.dto;

import lombok.AllArgsConstructor;
import lombok.Getter;

@Getter
@AllArgsConstructor
public class ReportChangeResponse {
private String message;
}
14 changes: 14 additions & 0 deletions src/main/java/org/ezcode/codetest/application/report/dto/ReportDetailResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package org.ezcode.codetest.application.report.dto;

public record ReportDetailResponse(
Long reportId,
String reporterEmail,
Long targetId,
String targetType,
String reportType,
String reportStatus,
String message,
String imageUrl,
String createdAt,
String modifiedAt
) {}
12 changes: 12 additions & 0 deletions src/main/java/org/ezcode/codetest/application/report/dto/ReportListResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package org.ezcode.codetest.application.report.dto;

public record ReportListResponse(
Long reportId,
String reporterEmail,
Long targetId,
String targetType,
String reportType,
String reportStatus,
String message,
String createdAt
) {}
20 changes: 20 additions & 0 deletions src/main/java/org/ezcode/codetest/application/report/dto/ReportRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
package org.ezcode.codetest.application.report.dto;

import jakarta.validation.constraints.NotBlank;
import jakarta.validation.constraints.NotNull;

public record ReportRequest(
@NotNull
Long targetId,

@NotBlank
String targetType,

@NotBlank
String reportType,

@NotBlank
String message,

String imageUrl
) {}
12 changes: 12 additions & 0 deletions src/main/java/org/ezcode/codetest/application/report/dto/ReportResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package org.ezcode.codetest.application.report.dto;

import io.swagger.v3.oas.annotations.media.Schema;

@Schema(name = "ReportResponse", description = "신고 DTO")
public record ReportResponse(
Long reportId,
String status,
String type,
String message,
String imageUrl
) {}
13 changes: 13 additions & 0 deletions src/main/java/org/ezcode/codetest/application/report/dto/ReportStatusUpdateRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package org.ezcode.codetest.application.report.dto;

import jakarta.validation.constraints.NotBlank;
import org.ezcode.codetest.domain.report.model.ReportStatus;

public record ReportStatusUpdateRequest(
@NotBlank
String newStatus // 예시 RESOLVED(해결됨), REJECTED(거절)
) {
public ReportStatus toEnum() {
return ReportStatus.from(newStatus);
}
}
1 change: 1 addition & 0 deletions src/main/java/org/ezcode/codetest/application/report/port/ReportRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
package org.ezcode.codetest.application.report.port;


public interface ReportRepository {
}
Comment on lines +3 to 5
Copy link

@coderabbitai coderabbitai bot Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

포트 인터페이스 구현 누락
application.report.port.ReportRepository는 서비스 레이어에서 의존할 포트 정의로 보이나, 메서드 시그니처가 없고 이를 구현한 인프라스트럭처 어댑터도 존재하지 않습니다. 이대로면 의존성 주입 시 빈 충돌 또는 NoSuchBeanDefinitionException이 발생할 수 있습니다.

🤖 Prompt for AI Agents 
In
src/main/java/org/ezcode/codetest/application/report/port/ReportRepository.java
at lines 3 to 5, the ReportRepository interface is empty and lacks method
signatures, and there is no implementing infrastructure adapter. Define
appropriate method signatures in this interface that represent the required
report-related operations, then create a corresponding implementation class in
the infrastructure layer to implement these methods. This will ensure proper
dependency injection and avoid bean definition errors.

97 changes: 97 additions & 0 deletions src/main/java/org/ezcode/codetest/application/report/service/ReportService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
package org.ezcode.codetest.application.report.service;

import org.ezcode.codetest.application.report.dto.*;
import org.ezcode.codetest.domain.report.model.*;
import org.ezcode.codetest.domain.report.repository.ReportRepository;
import org.ezcode.codetest.domain.user.model.entity.User;
import org.ezcode.codetest.domain.user.repository.UserRepository;
import org.springframework.data.domain.*;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;

import lombok.RequiredArgsConstructor;

@Service
@RequiredArgsConstructor
public class ReportService {

private final UserRepository userRepository;
private final ReportRepository reportRepository;

//신규 신고 생성
@Transactional
public ReportResponse submitReport(Long reporterId, ReportRequest request) {
User reporter = userRepository.findUserById(reporterId)
.orElseThrow(() -> new IllegalArgumentException("신고자 없음"));

ReportTargetType targetType = ReportTargetType.valueOf(request.targetType().toUpperCase());
ReportType reportType = ReportType.from(request.reportType());
Comment on lines +27 to +28
Copy link

@coderabbitai coderabbitai bot Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Enum 변환 시 예외 처리 추가 필요

문자열을 Enum으로 변환할 때 IllegalArgumentException이 발생할 수 있지만 적절한 예외 처리가 없습니다.

다음과 같이 예외 처리를 추가하세요:

-        ReportTargetType targetType = ReportTargetType.valueOf(request.targetType().toUpperCase());
-        ReportType reportType      = ReportType.from(request.reportType());
+        ReportTargetType targetType;
+        ReportType reportType;
+        
+        try {
+            targetType = ReportTargetType.valueOf(request.targetType().toUpperCase());
+            reportType = ReportType.from(request.reportType());
+        } catch (IllegalArgumentException e) {
+            throw new IllegalArgumentException("유효하지 않은 신고 타입입니다: " + e.getMessage());
+        }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ReportTargetType targetType = ReportTargetType.valueOf(request.targetType().toUpperCase());
ReportType reportType = ReportType.from(request.reportType());
ReportTargetType targetType;
ReportType reportType;
try {
targetType = ReportTargetType.valueOf(request.targetType().toUpperCase());
reportType = ReportType.from(request.reportType());
} catch (IllegalArgumentException e) {
throw new IllegalArgumentException("유효하지 않은 신고 타입입니다: " + e.getMessage());
}
🤖 Prompt for AI Agents 
In
src/main/java/org/ezcode/codetest/application/report/service/ReportService.java
around lines 27 to 28, the conversion from string to Enum using valueOf and from
methods can throw IllegalArgumentException, but there is no exception handling.
Add try-catch blocks around these conversions to catch IllegalArgumentException
and handle it appropriately, such as throwing a custom exception or returning a
meaningful error response.


if (targetType == ReportTargetType.USER && reporterId.equals(request.targetId())) {
throw new IllegalArgumentException("자기 자신은 신고할 수 없습니다.");
}
Comment on lines +30 to +32
Copy link

@coderabbitai coderabbitai bot Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

🧩 Verification correct

비즈니스 로직 검증 개선 제안

자기 자신 신고 방지 로직이 있지만, AI 요약에 따르면 ReportDomainService에 이미 이 검증 로직이 캡슐화되어 있다고 합니다. 중복 검증을 피하고 도메인 서비스를 활용하는 것이 좋겠습니다.

ReportDomainService의 존재와 검증 로직을 확인해주세요:

🏁 Script executed:

#!/bin/bash
# ReportDomainService 클래스 존재 확인 및 검증 로직 조회
fd "ReportDomainService" --type f --exec cat {}

Length of output: 642

비즈니스 로직 검증 개선 제안

자기 자신 신고 방지 로직이 있지만, AI 요약에 따르면 ReportDomainService에 이미 이 검증 로직이 캡슐화되어 있다고 합니다. 중복 검증을 피하고 도메인 서비스를 활용하는 것이 좋겠습니다.

ReportDomainService의 존재와 검증 로직을 확인해주세요:

#!/bin/bash
# ReportDomainService 클래스 존재 확인 및 검증 로직 조회
fd "ReportDomainService" --type f --exec cat {}
🤖 Prompt for AI Agents 
In
src/main/java/org/ezcode/codetest/application/report/service/ReportService.java
around lines 30 to 32, the self-report prevention logic is currently implemented
directly in the service. Since this validation is already encapsulated within
ReportDomainService, remove the duplicate check here and instead call the
appropriate validation method from ReportDomainService to handle this logic,
ensuring single responsibility and avoiding redundant validation.

Comment on lines +27 to +32
Copy link

@coderabbitai coderabbitai bot Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Enum 변환과 검증 로직을 개선해야 합니다.

Enum 변환에서 발생할 수 있는 예외 처리가 없고, 자기 자신 신고 방지 로직이 도메인 서비스에 있다고 명시되어 있지만 여기에 중복 구현되어 있습니다.

+import org.ezcode.codetest.domain.report.service.ReportDomainService;

@Service
@RequiredArgsConstructor
public class ReportService {

    private final UserRepository userRepository;
    private final ReportRepository reportRepository;
+   private final ReportDomainService reportDomainService;

     @Transactional
     public ReportResponse submitReport(Long reporterId, ReportRequest request) {
         User reporter = userRepository.findUserById(reporterId)
                 .orElseThrow(() -> new IllegalArgumentException("신고자를 찾을 수 없습니다."));

-        ReportTargetType targetType = ReportTargetType.valueOf(request.targetType().toUpperCase());
-        ReportType reportType      = ReportType.from(request.reportType());
-
-        if (targetType == ReportTargetType.USER && reporterId.equals(request.targetId())) {
-            throw new IllegalArgumentException("자기 자신은 신고할 수 없습니다.");
-        }
+        ReportTargetType targetType;
+        ReportType reportType;
+        
+        try {
+            targetType = ReportTargetType.valueOf(request.targetType().toUpperCase());
+            reportType = ReportType.from(request.reportType());
+        } catch (IllegalArgumentException e) {
+            throw new IllegalArgumentException("잘못된 신고 타입입니다.");
+        }
+        
+        reportDomainService.validateReportSubmission(reporterId, request.targetId(), targetType);
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ReportTargetType targetType = ReportTargetType.valueOf(request.targetType().toUpperCase());
ReportType reportType = ReportType.from(request.reportType());
if (targetType == ReportTargetType.USER && reporterId.equals(request.targetId())) {
throw new IllegalArgumentException("자기 자신은 신고할 수 없습니다.");
}
// src/main/java/org/ezcode/codetest/application/report/service/ReportService.java
import org.ezcode.codetest.domain.report.service.ReportDomainService;
@Service
@RequiredArgsConstructor
public class ReportService {
private final UserRepository userRepository;
private final ReportRepository reportRepository;
private final ReportDomainService reportDomainService;
@Transactional
public ReportResponse submitReport(Long reporterId, ReportRequest request) {
User reporter = userRepository.findUserById(reporterId)
.orElseThrow(() -> new IllegalArgumentException("신고자를 찾을 수 없습니다."));
ReportTargetType targetType;
ReportType reportType;
try {
targetType = ReportTargetType.valueOf(request.targetType().toUpperCase());
reportType = ReportType.from(request.reportType());
} catch (IllegalArgumentException e) {
throw new IllegalArgumentException("잘못된 신고 타입입니다.");
}
reportDomainService.validateReportSubmission(reporterId, request.targetId(), targetType);
// ... 기존 로직 계속 (e.g., build & save Report, return response) ...
}
}
🤖 Prompt for AI Agents 
In
src/main/java/org/ezcode/codetest/application/report/service/ReportService.java
around lines 27 to 32, the enum conversion lacks exception handling and the
self-report prevention logic is duplicated here despite being in the domain
service. To fix this, add proper try-catch blocks or use safe enum conversion
methods to handle invalid values gracefully, and remove the self-report
validation from this service to avoid duplication, relying solely on the domain
service for that check.

🛠️ Refactor suggestion

Enum 변환 시 예외 처리를 개선해야 합니다.

valueOf() 메소드는 잘못된 문자열이 전달될 경우 IllegalArgumentException을 발생시킵니다. 더 명확한 에러 메시지를 제공하거나 커스텀 예외를 사용하는 것을 고려해보세요.

- ReportTargetType targetType = ReportTargetType.valueOf(request.targetType().toUpperCase());
- ReportType reportType      = ReportType.from(request.reportType());
+ ReportTargetType targetType;
+ ReportType reportType;
+ 
+ try {
+     targetType = ReportTargetType.valueOf(request.targetType().toUpperCase());
+     reportType = ReportType.from(request.reportType());
+ } catch (IllegalArgumentException e) {
+     throw new IllegalArgumentException("유효하지 않은 신고 타입입니다: " + e.getMessage());
+ }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
ReportTargetType targetType = ReportTargetType.valueOf(request.targetType().toUpperCase());
ReportType reportType = ReportType.from(request.reportType());
if (targetType == ReportTargetType.USER && reporterId.equals(request.targetId())) {
throw new IllegalArgumentException("자기 자신은 신고할 수 없습니다.");
}
ReportTargetType targetType;
ReportType reportType;
try {
targetType = ReportTargetType.valueOf(request.targetType().toUpperCase());
reportType = ReportType.from(request.reportType());
} catch (IllegalArgumentException e) {
throw new IllegalArgumentException("유효하지 않은 신고 타입입니다: " + e.getMessage());
}
if (targetType == ReportTargetType.USER && reporterId.equals(request.targetId())) {
throw new IllegalArgumentException("자기 자신은 신고할 수 없습니다.");
}
🤖 Prompt for AI Agents 
In
src/main/java/org/ezcode/codetest/application/report/service/ReportService.java
around lines 27 to 32, the use of ReportTargetType.valueOf() can throw an
IllegalArgumentException with a generic message if the input string is invalid.
To improve this, catch the exception thrown by valueOf(), then throw a new
exception with a clearer, custom error message or use a custom exception type to
indicate the invalid enum conversion more explicitly.


Report report = new Report(reporter,
request.targetId(),
targetType,
request.message(),
request.imageUrl(),
reportType);

reportRepository.save(report);

return new ReportResponse(
report.getId(),
report.getReportStatus().name(),
report.getReportType().name(),
report.getMessage(),
report.getImageUrl()
);
}

//신고 목록 페이징
@Transactional(readOnly = true)
public Page<ReportListResponse> getReportList(Pageable pageable) {
return reportRepository.findAll(pageable)
.map(r -> new ReportListResponse(
r.getId(),
r.getReporter().getEmail(),
r.getTargetId(),
r.getTargetType().name(),
r.getReportType().name(),
r.getReportStatus().name(),
r.getMessage(),
r.getCreatedAt().toString()
Copy link

@coderabbitai coderabbitai bot Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

날짜 형식을 명시적으로 지정하세요.

toString() 메소드 사용 시 예측 가능한 형식이 보장되지 않습니다. 일관된 날짜 형식을 위해 DateTimeFormatter를 사용하는 것을 권장합니다.

- r.getCreatedAt().toString()
+ r.getCreatedAt().format(DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss"))

클래스 상단에 다음 import를 추가해야 합니다:

import java.time.format.DateTimeFormatter;
🤖 Prompt for AI Agents 
In
src/main/java/org/ezcode/codetest/application/report/service/ReportService.java
at line 64, replace the use of r.getCreatedAt().toString() with formatting using
DateTimeFormatter to ensure a consistent and predictable date format. Import
java.time.format.DateTimeFormatter at the top of the file, define a formatter
with the desired pattern, and apply it to r.getCreatedAt() to convert the date
to a string.

));
}
Comment on lines +54 to +66
Copy link

@coderabbitai coderabbitai bot Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Null 안전성과 데이터 포맷팅을 개선해야 합니다.

Reporter 이메일에 대한 null 체크가 없고, 날짜를 문자열로 변환할 때 적절한 포맷팅이 필요합니다.

+import java.time.format.DateTimeFormatter;
+
+    private static final DateTimeFormatter DATE_FORMATTER = DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss");

     @Transactional(readOnly = true)
     public Page<ReportListResponse> getReportList(Pageable pageable) {
         return reportRepository.findAll(pageable)
                 .map(r -> new ReportListResponse(
                         r.getId(),
-                        r.getReporter().getEmail(),
+                        r.getReporter() != null ? r.getReporter().getEmail() : "알 수 없음",
                         r.getTargetId(),
                         r.getTargetType().name(),
                         r.getReportType().name(),
                         r.getReportStatus().name(),
                         r.getMessage(),
-                        r.getCreatedAt().toString()
+                        r.getCreatedAt().format(DATE_FORMATTER)
                 ));
     }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
public Page<ReportListResponse> getReportList(Pageable pageable) {
return reportRepository.findAll(pageable)
.map(r -> new ReportListResponse(
r.getId(),
r.getReporter().getEmail(),
r.getTargetId(),
r.getTargetType().name(),
r.getReportType().name(),
r.getReportStatus().name(),
r.getMessage(),
r.getCreatedAt().toString()
));
}
import java.time.format.DateTimeFormatter;
private static final DateTimeFormatter DATE_FORMATTER = DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss");
@Transactional(readOnly = true)
public Page<ReportListResponse> getReportList(Pageable pageable) {
return reportRepository.findAll(pageable)
.map(r -> new ReportListResponse(
r.getId(),
r.getReporter() != null
? r.getReporter().getEmail()
: "알 수 없음",
r.getTargetId(),
r.getTargetType().name(),
r.getReportType().name(),
r.getReportStatus().name(),
r.getMessage(),
r.getCreatedAt().format(DATE_FORMATTER)
));
}
🤖 Prompt for AI Agents 
In
src/main/java/org/ezcode/codetest/application/report/service/ReportService.java
around lines 54 to 66, add a null check for reporter email to avoid potential
NullPointerException and format the createdAt date using a proper date formatter
instead of calling toString() directly. Use Optional or conditional checks to
safely handle null reporter emails and apply a standard date format like
ISO_LOCAL_DATE_TIME for createdAt before passing it to the ReportListResponse
constructor.


//신고 상세
@Transactional(readOnly = true)
public ReportDetailResponse getReportDetail(Long reportId) {
Report r = reportRepository.findById(reportId)
.orElseThrow(() -> new IllegalArgumentException("신고가 존재하지 않습니다."));

return new ReportDetailResponse(
r.getId(),
r.getReporter().getEmail(),
r.getTargetId(),
r.getTargetType().name(),
r.getReportType().name(),
r.getReportStatus().name(),
r.getMessage(),
r.getImageUrl(),
r.getCreatedAt().toString(),
r.getModifiedAt().toString()
Comment on lines +83 to +84
Copy link

@coderabbitai coderabbitai bot Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

날짜 형식 통일성을 위해 DateTimeFormatter 사용을 권장합니다.

앞서 언급한 것과 동일한 이슈입니다. 일관된 날짜 형식을 위해 포맷터를 사용하세요.

- r.getCreatedAt().toString(),
- r.getModifiedAt().toString()
+ r.getCreatedAt().format(DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss")),
+ r.getModifiedAt().format(DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss"))
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
r.getCreatedAt().toString(),
r.getModifiedAt().toString()
r.getCreatedAt().format(DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss")),
r.getModifiedAt().format(DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss"))
🤖 Prompt for AI Agents 
In
src/main/java/org/ezcode/codetest/application/report/service/ReportService.java
around lines 83 to 84, the code converts dates to strings using toString(),
which leads to inconsistent date formats. Replace these calls with a
DateTimeFormatter instance to format the dates consistently according to a
defined pattern, ensuring uniform date representation throughout the
application.

);
}
Comment on lines +69 to +86
Copy link

@coderabbitai coderabbitai bot Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

일관된 에러 메시지와 null 안전성을 적용해야 합니다.

에러 메시지를 일관되게 유지하고, null 안전성을 보장해야 합니다.

     @Transactional(readOnly = true)
     public ReportDetailResponse getReportDetail(Long reportId) {
         Report r = reportRepository.findById(reportId)
-                .orElseThrow(() -> new IllegalArgumentException("신고가 존재하지 않습니다."));
+                .orElseThrow(() -> new IllegalArgumentException("신고를 찾을 수 없습니다."));

         return new ReportDetailResponse(
                 r.getId(),
-                r.getReporter().getEmail(),
+                r.getReporter() != null ? r.getReporter().getEmail() : "알 수 없음",
                 r.getTargetId(),
                 r.getTargetType().name(),
                 r.getReportType().name(),
                 r.getReportStatus().name(),
                 r.getMessage(),
                 r.getImageUrl(),
-                r.getCreatedAt().toString(),
-                r.getModifiedAt().toString()
+                r.getCreatedAt().format(DATE_FORMATTER),
+                r.getModifiedAt() != null ? r.getModifiedAt().format(DATE_FORMATTER) : null
         );
     }

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In
src/main/java/org/ezcode/codetest/application/report/service/ReportService.java
around lines 69 to 86, the error message thrown when the report is not found
should be made consistent with other error messages in the application, and null
safety should be ensured when accessing report properties. Update the exception
message to match the standard format used elsewhere and add null checks or use
Optional methods to safely access nested properties like reporter and timestamps
to prevent potential NullPointerExceptions.


//신고 상태 변경
@Transactional
public void updateReportStatus(Long reportId, ReportStatusUpdateRequest req) {
Report report = reportRepository.findById(reportId)
.orElseThrow(() -> new IllegalArgumentException("신고가 존재하지 않습니다."));

ReportStatus newStatus = req.toEnum();
report.updateStatus(newStatus);
}
}
43 changes: 21 additions & 22 deletions src/main/java/org/ezcode/codetest/domain/report/model/Report.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,59 +1,58 @@
package org.ezcode.codetest.domain.report.model;

import jakarta.persistence.*;
import org.ezcode.codetest.common.base.entity.BaseEntity;
import org.ezcode.codetest.domain.user.model.entity.User;

import jakarta.persistence.Column;
import jakarta.persistence.Entity;
import jakarta.persistence.EnumType;
import jakarta.persistence.Enumerated;
import jakarta.persistence.GeneratedValue;
import jakarta.persistence.GenerationType;
import jakarta.persistence.Id;
import jakarta.persistence.JoinColumn;
import jakarta.persistence.Table;
import lombok.AccessLevel;
import lombok.Getter;
import lombok.NoArgsConstructor;
import jakarta.persistence.ManyToOne;

@Getter
@Entity
@Table(name = "report")
@NoArgsConstructor(access = AccessLevel.PROTECTED)
@Getter
public class Report extends BaseEntity {
@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)

@Id @GeneratedValue(strategy = GenerationType.IDENTITY)
private Long id;

@ManyToOne
@ManyToOne(fetch = FetchType.LAZY)
@JoinColumn(name = "reporter_id", nullable = false)
private User reporter;

@ManyToOne
@JoinColumn(name = "target_id", nullable = false)
private User target;
@Column(nullable = false)
private Long targetId;

@Column(nullable = false, length = 50)
@Enumerated(EnumType.STRING)
private ReportTargetType targetType;
@Column(nullable = false)
private String message;

@Column(nullable = false)
private String imageUrl;

@Enumerated(EnumType.STRING)
@Column(nullable = false)
@Column(nullable = false, length = 50)
private ReportType reportType;

@Column(nullable = false, length = 50)
@Enumerated(EnumType.STRING)
private ReportStatus reportStatus;

public Report(User reporter, User target, String message, String imageUrl,
ReportType reportType) {
public Report(User reporter, Long targetId, ReportTargetType targetType,
String message, String imageUrl, ReportType reportType) {
this.reporter = reporter;
this.target = target;
this.targetId = targetId;
this.targetType = targetType;
this.message = message;
this.imageUrl = imageUrl;
this.reportType = reportType;
this.reportStatus = ReportStatus.PENDING;
}

public void updateStatus(ReportStatus newStatus) {
this.reportStatus = newStatus;
}

}
14 changes: 8 additions & 6 deletions src/main/java/org/ezcode/codetest/domain/report/model/ReportStatus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,28 @@

import java.util.Arrays;

import com.fasterxml.jackson.annotation.JsonCreator;
import lombok.Getter;

@Getter
public enum ReportStatus {
PENDING("대기 중"), // 대기 중
IN_PROGRESS("검토 중"), // 검토 중
RESOLVED("조치 완료"), // 조치 완료
REJECTED("기각됨"), // 기각됨
CANCELED("사용자 철회"); // 사용자 철회 (옵션);
PENDING("대기 중"),
IN_PROGRESS("검토 중"),
RESOLVED("조치 완료"),
REJECTED("기각됨"),
CANCELED("사용자 철회");

private final String description;

ReportStatus(String description) {
this.description = description;
}

@JsonCreator
public static ReportStatus from(String reportStatus) {
return Arrays.stream(ReportStatus.values())
.filter(r -> r.name().equalsIgnoreCase(reportStatus))
.findFirst()
.orElseThrow(() -> new IllegalArgumentException("Invalid reportStatus input : " + reportStatus));
.orElseThrow(() -> new IllegalArgumentException("목록에 없는 신고 상태 입니다. : " + reportStatus));
}
}
9 changes: 9 additions & 0 deletions src/main/java/org/ezcode/codetest/domain/report/model/ReportTargetType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package org.ezcode.codetest.domain.report.model;

public enum ReportTargetType {
USER,
PROBLEM,
POST,
COMMENT,
OTHER
}
13 changes: 7 additions & 6 deletions src/main/java/org/ezcode/codetest/domain/report/model/ReportType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

@Getter
public enum ReportType {
PROBLEM_ERROR("문제 오류"),
PROFANITY("욕설/비속어"),
SPAM("스팸/도배"),
SEXUAL_CONTENT("음란성 표현"),
Expand All @@ -23,10 +24,10 @@ public enum ReportType {
this.description = description;
}

public static ReportType from(String reportType) {
return Arrays.stream(ReportType.values())
.filter(r -> r.name().equalsIgnoreCase(reportType))
.findFirst()
.orElseThrow(() -> new IllegalArgumentException("Invalid reportType input : " + reportType));
public static ReportType from(String value) {
return Arrays.stream(values())
.filter(r -> r.name().equalsIgnoreCase(value))
.findFirst()
.orElseThrow(() -> new IllegalArgumentException("목록에 없는 신고 타입입니다. : " + value));
}
}
}
7 changes: 7 additions & 0 deletions src/main/java/org/ezcode/codetest/domain/report/repository/ReportRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package org.ezcode.codetest.domain.report.repository;

import org.ezcode.codetest.domain.report.model.Report;
import org.springframework.data.jpa.repository.JpaRepository;

public interface ReportRepository extends JpaRepository<Report, Long> {
}
15 changes: 14 additions & 1 deletion src/main/java/org/ezcode/codetest/domain/report/service/ReportDomainService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,17 @@
package org.ezcode.codetest.domain.report.service;

public class ReportDomainService {
import lombok.RequiredArgsConstructor;
import org.ezcode.codetest.domain.report.model.ReportTargetType;
import org.ezcode.codetest.domain.user.model.entity.User;
import org.springframework.stereotype.Service;

@Service
@RequiredArgsConstructor
public class ReportDomainService{

public void validate(User reporter, Long targetId, ReportTargetType targetType) {
if (targetType == ReportTargetType.USER && reporter.getId().equals(targetId)) {
throw new IllegalArgumentException("자기 자신은 신고할 수 없습니다.");
}
}
}
4 changes: 0 additions & 4 deletions src/main/java/org/ezcode/codetest/presentation/ReportController.java
View file
Open in desktop

This file was deleted.

Loading