fix warning: ignore last part for rewriting when uneven count #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezzoom was generating many warnings like the following [Fri Dec 14 09:59:12 2012] [warn] [client 66.249.76.102] mod_fcgid: stderr: PHP Notice: Undefined offset: 13 in /var/www/magento/htdocs/ezzoom.php on line 138 that happens because ezzoom adds '/ZOOM_INDEX' to the uri before splitting. the fix will just ignore the last component. in my (limited) testing, it has always been 'ZOOM_INDEX'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ezzoom was generating many warnings like the following
[Fri Dec 14 09:59:12 2012] [warn] [client 66.249.76.102] mod_fcgid: stderr: PHP Notice: Undefined offset: 13 in /var/www/magento/htdocs/ezzoom.php on line 138
that happens because ezzoom adds '/ZOOM_INDEX' to the uri before splitting.
the fix will just ignore the last component. in my (limited) testing, it has always been 'ZOOM_INDEX'.