Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftpignore18 #58

Merged
merged 1 commit into from
Jan 3, 2013
Merged

Ftpignore18 #58

merged 1 commit into from
Jan 3, 2013

Conversation

peteruhnak
Copy link
Contributor

Since I have solved the matching in another way I can hapilly use original fnmatch. There are also unittests for path matching. If we want to have tests for the whole thing then we'll need some mock, like XConnecting does. #18

@niklasf
Copy link
Contributor

niklasf commented Mar 29, 2012

Awesome work!

One finding: It appears that the ignoring doesn't work when I execute git ftp in a subdirectory in the repository. At least my .gitftpignore file was uploaded when I was in a subdirectory. Can you reproduce that, or do you need more info?

@peteruhnak
Copy link
Contributor Author

Thank you. I can indeed reproduce it and I'll fix it shortly.

@niklasf
Copy link
Contributor

niklasf commented Apr 12, 2012

Excellent, thank you!

@niklasf
Copy link
Contributor

niklasf commented Apr 26, 2012

bde9622 probably can't be automatically merged. Should be easy, though.

@dl1ely
Copy link
Contributor

dl1ely commented Jan 3, 2013

Could you please pull this in? The code works ok for me, i synced it in into my fork of ezyang/git-ftp and will base my future work upon that, as i desperately needed the feature. It would be unfortunate to let the project split in two directions. Thanks.

@ezyang
Copy link
Owner

ezyang commented Jan 3, 2013

It looks like the merge is no longer clean. Could you submit a new PR with your synced in fork?

@ezyang ezyang merged commit 97adafa into ezyang:master Jan 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants