[#23] pg수수료 ApplicationStartedEvent 로컬캐싱 전환 #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SinJeongEun
commented
Nov 23, 2025
| private String buildRouteKey(PayMethod payMethod, PayProvider payProvider) { | ||
| return ROUTE_KEY_PREFIX + payMethod.name() + ":" + payProvider.name(); | ||
| } | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
@f-lab-lyan 🙂
redis 캐싱정보에서 수수료는 제외했습니다.
pg health 는 분산환경에서 실시간으로 모두 반영해야되는 정보라서 redis 에 유지했습니다!
|
|
||
| // 캐시 초기화 @EventListener(ApplicationReadyEvent.class) | ||
| paymentPgRouter.initPgCache(); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
PaymentPgRouter 단위테스트 입니다
PaymentPgRouter 생성자에서 pg구현체 list 를 받고있어서 mock 데이터로 직접 생성했습니다.
| } | ||
| ); | ||
|
|
||
| application.run(); |
Collaborator
Author
There was a problem hiding this comment.
ApplicationStartedEvent 로 db조회해서 수수료를 로컬캐시 pgFeeCache에 저장하고 있습니다.
런타임 전에 완료되는 것을 검증해봤습니다.
(pgFeeCache 가 private 라서 주석으로 커밋했습니다.)
SinJeongEun
commented
Nov 23, 2025
| @EventListener(ApplicationStartedEvent.class) | ||
| public void initPgCache() { | ||
| setPgFeeCache(); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
PostConstruct 는 싱글톤 생성 락에서 실행되어, 외부bean작업 포함되는게 좋지 않다고해서
ApplicationStartedEvent 시에 초기화하는 방향으로 수정해봤습니다.
SinJeongEun
commented
Nov 23, 2025
| @Scheduled(cron = "0 * * * * *") | ||
| private void refreshPgCache() { | ||
| setPgFeeCache(); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
수수료 로컬캐시를 매일 0시에 업데이트 되는 코드를 추가했습니다.
Collaborator
There was a problem hiding this comment.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.매일 0시에 수수료정보 refresh