[#31] 회차별 좋아요 등록/해제 #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
f-lab-saponin
suggested changes
Jan 12, 2026
f-lab-saponin
left a comment
f-lab-saponin
left a comment
There was a problem hiding this comment.
회차별 좋아요 확인했습니다. 고생하셨습니다! 리뷰한번 확인부탁드립니다!!
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| public class EpisodeException extends RuntimeException { |
There was a problem hiding this comment.
EpisodeException 이게 사용중인 곳이 없어서 사용하는지 한번 확인부탁드려요!
Comment on lines
+42
to
+44
| Integer newCount = episodeRepository.findById(episodeId) | ||
| .map(ep -> ep.getLikeCount() == null ? 0 : ep.getLikeCount()) | ||
| .orElse(0); |
There was a problem hiding this comment.
여기도 굳이 다시 쿼리하지 않아도 업뎅트 성공했다면 likeCount + delta 로 반환해도될것 같아요.
Comment on lines
+19
to
+33
| @PostMapping("/create") | ||
| public ResponseEntity<EpisodeLikeResponse> like( | ||
| @AuthenticationPrincipal CustomUserPrincipal principal, | ||
| @Valid @RequestBody EpisodeLikeRequest req | ||
| ) { | ||
| EpisodeLikeResponse episodeLikeResponse | ||
| = episodeLikeService.like(principal.id(), req.episodeId()); | ||
|
|
||
| return ResponseEntity.ok(episodeLikeResponse); | ||
| } | ||
|
|
||
| @DeleteMapping("/delete/{episodeId}") | ||
| public ResponseEntity<EpisodeLikeResponse> unlike( | ||
| @AuthenticationPrincipal CustomUserPrincipal principal, | ||
| @PathVariable Long episodeId |
There was a problem hiding this comment.
| throw new AlreadyEpisodeLikeException(); | ||
| } | ||
|
|
||
| episodeLikeRepository.save(EpisodeLike.like(member, episode)); |
There was a problem hiding this comment.
member_id, episode_id 유니크 조건이 있으면 중복 인서트를 방지할 수 있을 것 같아요. 혹은 다른 좋은 방법이 있으면 적용해보면 좋아요.
Comment on lines
+12
to
+24
| @Modifying(clearAutomatically = true, flushAutomatically = true) | ||
| @Query(""" | ||
| UPDATE Episode e | ||
| SET e.likeCount = | ||
| CASE | ||
| WHEN :delta < 0 AND COALESCE(e.likeCount, 0) <= 0 | ||
| THEN 0 | ||
| ELSE COALESCE(e.likeCount, 0) + :delta | ||
| END | ||
| WHERE e.id = :episodeId | ||
| """) | ||
| void updateLikeCountSafely(@Param("episodeId") Long episodeId, | ||
| @Param("delta") int delta); |
There was a problem hiding this comment.
deleted_at IS NULL
조건은 필요없을지 고민이 필요해보여요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
테스트 내용