[#17] Redis INCR + Redis Streams 적용 #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blue000927
reviewed
Jan 10, 2026
Comment on lines
+30
to
+32
| private static final String STREAM_KEY = "group:join:stream"; | ||
| private static final String CONSUMER_GROUP = "group-join-processor"; | ||
| private static final String CONSUMER_NAME = "worker-1"; |
There was a problem hiding this comment.
Consume 속도가 이벤트가 많다면 느릴 것입니다.
고려해야할 사항:
- Consume 속도를 정확히 측정한다.
- Redis Streams 파티션과 워커의 개념을 인지하고, 다중 파티션과 다중 워커의 구조를 바꿔보는 것을 추천합니다.
pjy1368
reviewed
Jan 10, 2026
Comment on lines
+30
to
+32
| private static final String STREAM_KEY = "group:join:stream"; | ||
| private static final String CONSUMER_GROUP = "group-join-processor"; | ||
| private static final String CONSUMER_NAME = "worker-1"; |
| public void init() { | ||
| createConsumerGroupIfNotExists(); | ||
|
|
||
| Thread consumerThread = new Thread(() -> startConsuming(), "event-consumer-worker-1"); |
There was a problem hiding this comment.
CONSUMER_NAME과 이 컨슈머를 매핑한 스레드 간의 이름이 헷갈릴 여지가 있어서 둘다 상수로 관리하면 어떨까요?
아니면 나중에 다중 consumer를 고려하여, 스레드 이름을 짓는건 별도 buildConsumerThreadName() 같은 메서드를 추출해도 괜찮아보이네요.
Comment on lines
+71
to
+74
| StreamReadOptions.empty() | ||
| .count(10) | ||
| .block(Duration.ofSeconds(2)), | ||
| StreamOffset.create(STREAM_KEY, ReadOffset.lastConsumed()) |
Comment on lines
+80
to
+82
| for (MapRecord<String, Object, Object> record : records) { | ||
| processEvent(record); | ||
| } |
| String eventId = record.getId().getValue(); | ||
|
|
||
| try { | ||
| Map<Object, Object> event = record.getValue(); |
There was a problem hiding this comment.
Map<Object, Object> 대신 Java DTO Class로 정의할 수는 없을까요?
| } | ||
| } | ||
|
|
||
| private void handleFailedEvent(MapRecord<String, Object, Object> record, Exception e) { |
There was a problem hiding this comment.
이벤트 처리가 실패하면 곧바로 DLQ로 옮기기보다는 재시도 가능한 예외는 재시도할 수 있지 않을까요?
Comment on lines
+35
to
+36
| String queueKey = "group:" + groupId + ":queue"; | ||
| String streamKey = "group:join:stream"; |
There was a problem hiding this comment.
GroupJoinEventConsumer에 이미 streamKey 상수가 있으니 활용되면 좋겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
메인 리뷰어 지정
리뷰 시 참고 사항
TODO
References
#17 Redis INCR + Redis Streams 적용
체크리스트
고민 거리 (궁금한 점)