-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add/fix support for bazel coverage #151
Conversation
Thanks for this! I think it makes sense to change one of the CI targets to call |
No problem, thanks for the project. I gave it a try, but I can't really test it since I'm not sure how to actually trigger CI (or don't have permissions to). So feel free to revert and do it differently. |
I'll get to it today. |
@f0rmiga Could you take another look please when you have some time? I merged in |
Awesome, thanks! |
Type of change
bazel coverage <...>
with C/C++ targets was not working because thegcov
binary was not included in the runfiles. This was showing as a silent failure as an empty coverage report. The test log contains:Test plan
$ bazel coverage --instrument_test_targets --combined_report=lcov //examples/hello_world_cpp:hello_world_cpp_test $ genhtml --output genhtml "$(bazel info output_path)//_coverage/_coverage_report.dat"