Add text links filter #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f213
reviewed
Jul 5, 2023
|
|
||
| def filter(self, message: Message) -> bool: | ||
| if message.text is None: | ||
| return False # type: ignore | ||
|
|
||
| return len(self.extractor.find_urls(message.text)) >= 1 | ||
| entities_types = set([entity.type for entity in message.entities]) |
There was a problem hiding this comment.
Довольно сложно проверить без тестов, надеюсь ты это внимательно потестил
There was a problem hiding this comment.
Тут точно хорошо протестил
Идеально было бы, раз уж ты сюда полез, перейти полностью на |
da-maltsev
force-pushed
the
enhance-links-filter
branch
from
b64f59e
to
fb93f35
Compare
f213
reviewed
Jul 5, 2023
f213
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Немного отрефакторил класс фильтра по ссылкам.
Т.к. телеграм сам может определять тип содержимого, убрал библиотеку urlextract.
Логику фильтрации ссылок обычных и текстовых сделал одинаковой. (если активным пользователям и так можно отправлять текстовые ссылки, то зачем им этот костыль - если нужно, пусть тогда и обычную смогут отправить)
Немного освежил библиотеки, но без критических обновлений + использовал такую же версию python как в CI
Следующими ПР обновлю telegram-bot до 20+ (api там существенно поменялся, и все перевели на async) и потом тесты добавлю