Huge tooling update #195
Merged
Huge tooling update #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
f213
commented
Jan 7, 2024
•
f213
commented
- Poetry
- Ruff
- mypy
- Migration to PTB > 20 (async)
- Dropped the whole test suite, cuz i don't want to mess with asyncio: hope mypy will do its job well
hnthh
reviewed
Jan 9, 2024
| poetry run toml-sort pyproject.toml | ||
|
|
||
| lint: | ||
| poetry run ruff check src |
There was a problem hiding this comment.
Suggested change
| poetry run ruff check src | |
| poetry run ruff format --check src | |
| poetry run ruff check src |
— ruff check не то же самое, что ruff format --check ;)
There was a problem hiding this comment.
Ещё надо папку tests включить во все эти команды)
There was a problem hiding this comment.
А тестов на проекте больше нет, я их выпилил чтобы не морочиться с асинхронным интерфейсом :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.