Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #35 #36

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Issue #35 #36

merged 6 commits into from
Jul 2, 2024

Conversation

fa-fifi
Copy link
Owner

@fa-fifi fa-fifi commented Jul 2, 2024

No description provided.

@fa-fifi fa-fifi linked an issue Jul 2, 2024 that may be closed by this pull request
@fa-fifi fa-fifi merged commit ed255e2 into main Jul 2, 2024
1 check passed
@fa-fifi fa-fifi deleted the issue#35 branch July 2, 2024 07:46
if (securedRefreshToken == null) {
developer.log('No refresh token found.', name: 'keycloak_wrapper');
_streamController.add(false);
} else if (JWT.decode(securedRefreshToken).isExpired) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to optionally check if the token will expire soon and only refresh if it has expired or will expire in a given timespan?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong.

You want a method to check either the token will expired in a given timespan/duration?

For example, you want to know if the token will expired in the next 1 hour. Right?

Copy link

@lyio lyio Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, more like refreshTokenIfExpiresIn(Duration). Where the plugin refreshes the token if it will expire in the given time span or just ignore the request.

But I can easily check the expiry myself , don't worry about it

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply.

Yeah, it is possible but can u open a new issue for that particular feature so I can keep track of it?

@lyio
Copy link

lyio commented Jul 5, 2024

I know that you have already merged and released this, but I wanted to thank you for adding this feature so fast. 🙏 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for responseMode: 'query'
2 participants