armhf support #3
Conversation
…to work on armhf, and the watchdog to work for armhf. Modifies inception.py to default execute the panda_jpeg example. Modifies pre_download to elminate all tf dependencies since they're not needed and will crash the docker build when you're not building on an rpi. Modifies requirements.txt to only contain relevant packages, including a version locked grpc package needed for tensorflow. Everything else was moved into apt, some wheels weren't properly installing in docker. Signed-off-by: tanuj <[email protected]>
| @@ -585,5 +585,5 @@ def invoke(body): | |||
| ######################################################################## | |||
|
|
|||
| if __name__ == '__main__': | |||
| print(invoke()) | |||
| print(invoke(os.path.join(data_dir, 'cropped_panda.jpg'))) | |||
There was a problem hiding this comment.
Why did this change get made?
There was a problem hiding this comment.
when testing inception.py to make sure tensorflow worked, i wanted to run 'python3 inception.py', but the old version didn't supply a body arg so it crashed.
| @@ -13,20 +13,27 @@ | |||
| # want to install the CPU or GPU version of TensorFlow. | |||
| # | |||
| ################################################################ | |||
| # Wheel needs to be installed directly for tensorflow installation to work | |||
There was a problem hiding this comment.
These changes may break the regular x86_64 version, what if we added a new requirements-armhf.txt file?
There was a problem hiding this comment.
ah yes good catch. we'll need that
|
|
||
| RUN pip3 install -r requirements.txt | ||
|
|
||
| RUN wget https://storage.googleapis.com/download.tensorflow.org/deps/pi/2018_03_22/tensorflow-1.6.0-cp35-none-any.whl |
There was a problem hiding this comment.
can we && these instructions for fewer layers with rm tensorflow-1.6.0-cp35-none-any.whl being part of that same block?
There was a problem hiding this comment.
Since the pip req install is so tightly coupled to tensorflow, probably better to also group the installation of the wheel file itself too (the layer right after L43 as well..).
Adds Dockerfile.armhf with the dependencies needed to get tensorflow to work on armhf, and the watchdog to work for armhf.
Modifies inception.py to default execute the panda_jpeg example.
Modifies pre_download to eliminate all tf dependencies since they're not needed and will crash the docker build when you're not building on an rpi.
Modifies requirements.txt to only contain relevant packages, including a version locked grpc package needed for tensorflow. Everything else was moved into apt, some wheels weren't properly installing in docker.
Signed-off-by: tanuj [email protected]