Fix key event #101
Open
Fix key event #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 5, 2024 09:58
…n window or item level
faaxm
reviewed
May 11, 2024
.gitignore
Outdated
| @@ -3,3 +3,4 @@ | |||
| .idea | |||
| build | |||
| dep-libs | |||
| CMakeLists.txt.user | |||
There was a problem hiding this comment.
Please don't add any non project files to the .gitignore. There is already more in there than there should be actually. For files created by your editor, it is better to use a local .gitignore file: https://gist.github.com/subfuzion/db7f57fff2fb6998a16c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion the key events have to enter the event queue on item level and not at window level.
I had issues to send key events to deep nested items. My fix resolved this.
Same for mouse events. They should be posted to the item level as well.