Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when object children iterator is invalidated #90

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Fix crash when object children iterator is invalidated #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/src/Scene/Qt/QtItemTools.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,14 @@ QString GetObjectName(QObject* object)

QObject* FindChildItem(QObject* object, const QString& name)
{
if (object == nullptr) {
return nullptr;
}

using Index = QObjectList::size_type;
if (auto qquickitem = qobject_cast<const QQuickItem*>(object)) {
for (auto child : qquickitem->childItems()) {
for (Index i = 0; i < qquickitem->childItems().size(); ++i) {
auto child = qquickitem->childItems().at(i);
if (GetObjectName(child) == name) {
return child;
}
Expand All @@ -74,7 +80,8 @@ QObject* FindChildItem(QObject* object, const QString& name)
}
}
} else {
for (auto child : object->children()) {
for (Index i = 0; i < object->children().size(); ++i) {
auto child = object->children().at(i);
if (GetObjectName(child) == name) {
return child;
}
Expand Down