Fix skies being shifted down a few pixels compared to Woof 12.0.2 #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially fixes small differences in wall rendering between Woof 12 and 14.
Fixes skies being shifted down a few pixels compared to Woof 12.
rfomin
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Thanks, works good for me.
For (1), there are still occasional wall columns that vary slightly. I don't know the cause but it doesn't seem critical at the moment.
This is really hard to notice. Due to the nature of Doom's rendering and fixed math, I'm not sure that the rendering can be absolutely perfect at all resolutions.
ceski-1
changed the title
|
Just to be safe, I tested El Juancho's config with an aspect ratio forced to 3440:1440 and unfortunately the HOM appeared. I don't want to risk regressions for such a small improvement, so I reverted the wall rendering adjustment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: See comment further down.
old information
For (1), there are still occasional wall columns that vary slightly. I don't know the cause but it doesn't seem critical at the moment. Here's a zip file with screenshots and a save: woofsav3_shots.zip. Look at the wall in the middle left.
For this PR, I ran a modified version of the HOM test (#1525 (comment)) with the entire range of FOVs and it was fine: hom_with_fov.patch.