fix solid bg HOM

[rfomin]

Fix #1624

The right side of the status bar has a HOM going from 3200x2400 to 3440x1440.

@ceski-1 I can't reproduce it (or maybe I can't see it). Is it fixed for you?

[ceski-1]

@ceski-1 I can't reproduce it (or maybe I can't see it). Is it fixed for you?

If I run the HOM test code before this PR, a HOM line appears above the status bar with the automap active for various resolutions, just like Alaux's screenshot. If I apply the changes from this PR and run the HOM test again, the HOM line does not appear. Note that the HOM test code doesn't actually catch the HOM lines in I_CheckHOM() but if you watch the screen, you'll see them.

[rfomin]

If I run the HOM test code before this PR, a HOM line appears above the status bar with the automap active for various resolutions, just like Alaux's screenshot. If I apply the changes from this PR and run the HOM test again, the HOM line does not appear.

Right, this PR fixes that. It also fixes the right side of the "game window" with screenblocks < 10 on 3440x1440 for example.

Sorry I was not clear, I was talking about the right side of the status bar, which we discuss from this comment: #1525 (comment) I am no longer able to reproduce it.

[ceski-1]

Sorry I was not clear, I was talking about the right side of the status bar, which we discuss from this comment: #1525 (comment) I am no longer able to reproduce it.

No, it doesn't fix that problem: pic

[rfomin]

No, it doesn't fix that problem: pic

There's a black column on the right side of the status bar? I can't get it: pic I have merged "master" and "solid_bg_hom" into "video_test".

[ceski-1]

I have merged "master" and "solid_bg_hom" into "video_test".

Yes, I did the same. Clean config with dynamic_resolution 0. Command line: woof -devparm -test -verbose -warp 1. Patch:
homtest_solidbghom.patch Only difference is I made the HOM lines red, cut the other resolutions out, and made the delay 3 seconds instead of 3 tics.

[rfomin]

I still can't reproduce this. I've updated the HOM test branch, I'm only testing at 3440x1440 resolution and with the FOV test disabled.

Is the black column on the side of the status bar then filled with garbage pixels?

[rfomin]

It's just the transition from 3200x2400 to 3440x1440 for me.

This fixed it for me: 323f5bb I think that micro-optimisation is not important.

[ceski-1]

This fixed it for me: 323f5bb I think that micro-optimisation is not important.

Yes, that fixes it for me too.

[fabiangreffrath]

I don't even remember why this branch was here?

[rfomin]

There is another V_CopyRect in ST_drawWidgets, so it's not necessary to copy the ST_BAR itself in case of R_ExecuteSetViewSize. I don't think we need this complication.