add a "prev map" key binding #2046
Conversation
| @@ -2608,6 +2608,18 @@ boolean M_ShortcutResponder(const event_t *ev) | |||
| } | |||
| } | |||
|
|
|||
| if (M_InputActivated(input_menu_prevlevel)) | |||
| { | |||
| if (demoplayback && singledemo && !PLAYBACK_SKIP) | |||
There was a problem hiding this comment.
Not sure about this part.
There was a problem hiding this comment.
"Next Level" works during demoplayback. "Prev Level" would not be so practical - we would have to restart the demo from the beginning. I think we need demo compatible save/rewind to implement the "Prev Level" feature well.
There was a problem hiding this comment.
I think we need demo compatible save/rewind to implement the "Prev Level" feature well.
For demos, yes. But for regular play?
What if you start the game with -warp 1 2 and hit the "prev level" button? I would expect it to go back to E1M1, although this map has not been visited in the current run.
There was a problem hiding this comment.
For demos, yes. But for regular play?
Yes, I was talking about demos. Sure, we can implement "prev map" without demo playback support.
There was a problem hiding this comment.
Demo support for "prev level" would be very useful.
There was a problem hiding this comment.
Demo support for "prev level" would be very useful.
Then it will take a while until we have demo-compatible saves. DSDA-Doom has an implementation of it, but I want to try to extend zone memory with "relative pointers" idea: https://nullprogram.com/blog/2023/09/30/
instead of pointers I use signed integers whose value indicates an offset relative to itself
This would allow us to save/restore the entire playsim with a single memcpy. Not sure if this will work though.
| @@ -702,6 +702,7 @@ void M_BindInputVariables(void) | |||
|
|
|||
| BIND_INPUT(input_menu_reloadlevel, "Restart current level/demo"); | |||
| BIND_INPUT(input_menu_nextlevel, "Go to next level"); | |||
| BIND_INPUT(input_menu_prevlevel, "Go to previous level"); | |||
There was a problem hiding this comment.
It's config only? We don't have room for it in the "Key Bindings" menu. Maybe we should move player 1-4 to config:
There was a problem hiding this comment.
Yes, that's a good solution.
Fixes #2007