Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ audio #17

Merged
merged 3 commits into from
Dec 9, 2023
Merged

✨ audio #17

merged 3 commits into from
Dec 9, 2023

Conversation

fabienjuif
Copy link
Owner

@fabienjuif fabienjuif commented Dec 3, 2023 •
edited
Loading

TODOs

  • do not work on wasm
  • the asset is loaded for every explosion, look at "handles" to avoid this. This is clearly visible in browser network tab

@fabienjuif fabienjuif marked this pull request as ready for review December 9, 2023 09:56
@fabienjuif fabienjuif merged commit 73ff91b into main Dec 9, 2023
1 check passed
@fabienjuif fabienjuif deleted the sound branch December 9, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fabienjuif