Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset settings admin #145

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ar0ne
Copy link

@ar0ne ar0ne commented Apr 15, 2024


name: Reset setting (admin part)
about: Add button to admin panel that resets settings to default values
assignees: fabiocaccamo


This branch coupled with #128 and could be merged only after it.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests for the proposed changes.
  • I have run the tests and there are not errors.

ar0ne added 2 commits April 15, 2024 13:42
renamed method, added unit tests

added button to admin page for reseting
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.77%. Comparing base (fd891da) to head (8c2cb76).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   85.51%   85.77%   +0.26%     
==========================================
  Files          21       21              
  Lines         435      443       +8     
==========================================
+ Hits          372      380       +8     
  Misses         63       63              
Flag Coverage Δ
unittests 85.77% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabiocaccamo
Copy link
Owner

fabiocaccamo commented Apr 22, 2024

@ar0ne I see a lot of duplicated code of #128, I think it's better to wait until #128 will be merged and then rebase this one before continuing to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants