Skip to content

Commit

Permalink
Release 4.1.0
Browse files Browse the repository at this point in the history
  • Loading branch information
alfonsogarciacaro committed Apr 18, 2023
1 parent 79f968c commit 7db9778
Show file tree
Hide file tree
Showing 8 changed files with 36 additions and 20 deletions.
2 changes: 1 addition & 1 deletion build.fsx
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ let buildLibraryTs() =
copyFile (sourceDir </> "package.json") buildDirTs

// runTSLint buildDirTs
runTypeScriptWithArgs buildDirTs ["--outDir " + buildDirJs]
runTypeScriptWithArgs buildDirTs ["--outDir " + buildDirJs]
copyFile (buildDirTs </> "lib/big.d.ts") (buildDirJs </> "lib/big.d.ts")
copyFile (buildDirTs </> "package.json") buildDirJs

Expand Down
4 changes: 2 additions & 2 deletions src/Fable.Cli/Entry.fs
Original file line number Diff line number Diff line change
Expand Up @@ -359,11 +359,11 @@ let clean (args: CliArgs) language rootDir =
Log.always("Clean completed! Files deleted: " + string fileCount)

let getStatus = function
| JavaScript -> "stable"
| JavaScript
| TypeScript -> "stable"
| Python -> "beta"
| Rust -> "alpha"
| Dart -> "beta"
| TypeScript -> "beta"
| Php -> "experimental"

[<EntryPoint>]
Expand Down
13 changes: 3 additions & 10 deletions src/Fable.Cli/Fable.Cli.fsproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,9 @@
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<Version>4.1.0</Version>
<PackageVersion>4.1.0-beta-001</PackageVersion>
<PackageReleaseNotes>* Fix #3418: Single-Case Union Reflection
* Include declaration .d.ts files in fable-library
* Update FCS
* Python: Implement missing bigint functions @johannesmols
* TS: Fix #3415: ident type of uncurried lambdas
* TS: Don't use const enums to represent union tags
* TS: Fix function type annotation
* TS: Get generic types of generated members
* TS/JS: Sanitize class fields</PackageReleaseNotes>
<PackageVersion>4.1.0</PackageVersion>
<PackageReleaseNotes>* Set TypeScript compilation as stable
* Added Map.minKeyValue and maxKeyValue</PackageReleaseNotes>
<!-- Allow users with newer dotnet SDK to run Fable, see #1910 -->
<RollForward>Major</RollForward>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
Expand Down
5 changes: 5 additions & 0 deletions src/Fable.Cli/RELEASE_NOTES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
### 4.1.0

* Set TypeScript compilation as stable
* Added Map.minKeyValue and maxKeyValue

### 4.1.0-beta-001

* Fix #3418: Single-Case Union Reflection
Expand Down
2 changes: 1 addition & 1 deletion src/Fable.Transforms/Global/Compiler.fs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
namespace Fable

module Literals =
let [<Literal>] VERSION = "4.1.0-beta-001"
let [<Literal>] VERSION = "4.1.0"

type CompilerOptionsHelper =
static member Make(?language,
Expand Down
4 changes: 3 additions & 1 deletion src/Fable.Transforms/Transforms.Util.fs
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,9 @@ module AST =
// Other languages include a runtime check for options
| _ -> true
| ListHead | ListTail | TupleIndex _
| UnionTag | UnionField _ -> canHaveSideEffects e
| UnionTag -> canHaveSideEffects e
// Don't move union field getters after union case test in case TypeScript complains
| UnionField _ -> Compiler.Language = TypeScript || canHaveSideEffects e
| FieldGet info ->
if info.CanHaveSideEffects then true
else canHaveSideEffects e
Expand Down
2 changes: 1 addition & 1 deletion src/fable-library/README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# fable-library

This folder contains files (JS, TypeScript and F#) that are used mainly by the `Replacements` module of the compiler. The precompiled files are not distributed independently but are included in the compiler package.
Core library used by F# projects compiled with [Fable](https://fable.io).
24 changes: 20 additions & 4 deletions src/fable-library/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,21 @@
{
"private": true,
"sideEffects": false,
"type": "module"
}
"name": "fable-library",
"version": "0.1.0",
"description": "Core library used by F# projects compiled with fable.io",
"author": "Fable Contributors",
"license": "MIT",
"repository": {
"type": "git",
"url": "git+https://github.com/fable-compiler/Fable.git"
},
"bugs": {
"url": "https://github.com/fable-compiler/Fable/issues"
},
"homepage": "https://fable.io",
"keywords": [
"fable",
"fable-compiler",
"fsharp",
"F#"
]
}

3 comments on commit 7db9778

@ncave
Copy link
Collaborator

@ncave ncave commented on 7db9778 Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfonsogarciacaro JS build seems to be failing in main.

@alfonsogarciacaro
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my, this always when I add a "tiny" change to a release 🤦 Thanks for letting me know, I've sent a PR with the fix. Not sure if it needs a new release, it seems to affect only Nodejs. Before the release I tested fable-library with Vitejs and it worked.

@MangelMaxime
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfonsogarciacaro A new release would be nice, because some project does use Fable on top of Node.js.

So if people, update their Fable version they will break if I understood what you said.

Please sign in to comment.