This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor authentication codebase (#689)
* ISSUE-646 first stage of refactoring Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 further refactoring of login controller / service Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 more refactoring of login controller / service Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 minor Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 remove login service Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 further refactoring Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed all auth provider service compiler errors, introduced oso subscription service Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 added logout service, implementation to follow Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 moved account package Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 refactored authorize endpoint Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 refactored token package Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 cleanup Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 removed token package, started rewiring token controller Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 rewiring of token controller Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed token manager Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 refactored link service, added link provider factory Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 improve docs Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 refactored oauth providers further Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 few more fixes Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 refactored token controller Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fix test compiler errors Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed a lot, lots still broken Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed more compiler errors Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed all compiler errors Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fix test compiler errors Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 updated configuration to remove keycloak Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed more test compiler errors Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fix test issues Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 updated openshift config Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed test Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 more configuration defaults Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fix logout service to still call auth provider logout endpoint Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed test compiler errors Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed more tests Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 added factories Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 test infrastructure improvements Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fix more test compiler issues Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 testing framework enhancements Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 factory refinements Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 minor cleanup Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fix import cycles Signed-off-by: Shane Bryzak <[email protected]> * lock fabric8-common and use renamed package * ISSUE-646 refactored factories package, renaming Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 test compiler issues Signed-off-by: Shane Bryzak <[email protected]> * fix authorize_black_box_test.go * fix login_blackbox_test.go * ISSUE-646 fix build errors Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 renamed auth provider config params Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed compile errors Signed-off-by: Shane Bryzak <[email protected]> * fix logout test convert to a "black box" test, using a DBTestSuite so that the controller can be initialized with a proper `application.Application` Signed-off-by: Xavier Coulon <[email protected]> * update env vars in openshift template Signed-off-by: Xavier Coulon <[email protected]> * fix token_blackbox_test - expect access and refresh token to be renewed - expect type to be `bearer` - expect failure if access token was signed by an unknown key Signed-off-by: Xavier Coulon <[email protected]> * fix test end to end login service * fix login service end to end tests * remove changes not needed for this fix * remove changes not needed for this fix * check cause * ISSUE-646 added service tests to logout controller test Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 added IdentityProviderFactory Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 added dummy identity provider factory, fixed oauth2_blackbox_test Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed servicecontext bug in gormapplication, fixed tests in auth provider service tests Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 refactored factory wrappers to fix broken behaviour, fixed another test, yay! Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 factories should only be accessible from the service layer. this causes a few additional issues during testing, for which i'm still working on a solution... Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed other factory-related stuff Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 simplified factory Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 minor Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed more tests... Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed authentication provider service tests Signed-off-by: Shane Bryzak <[email protected]> * fix link_service_blackbox_test.go * ISSUE-646 fixed more tests Signed-off-by: Shane Bryzak <[email protected]> * fix(#684): remove create wit user for first time login (#686) * remove create wit user for first time login * docs: add documents to create user in DB * docs: add info about rhd_used_id * docs: add shell script to create user * chore: fix typos * ISSUE-646 fixed one problem... Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed TestRetrieveOSOServiceAccountTokenInvalidOnForcePull Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed another test Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed test compilation issue Signed-off-by: Shane Bryzak <[email protected]> * fix cluster service test and remove pointer on servicecontext.ServiceContext Signed-off-by: Xavier Coulon <[email protected]> * ISSUE-646 fixed token_storage_blackbox_test.go Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed oso subscription tests Signed-off-by: Shane Bryzak <[email protected]> * fix 'bearer' in unit test Signed-off-by: Xavier Coulon <[email protected]> * allow for 'bearer' authororization type Signed-off-by: Xavier Coulon <[email protected]> * ISSUE-646 fixed status test Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed users_blackbox_test Signed-off-by: Shane Bryzak <[email protected]> * fix logout controller tests added a `referer` header arg in the design so it can be passed in the goa-generated test functions and retrieved from the controller context, which avoids custom test (boilerplate) code marked a test as "skipped" for now, until clarification is provided Signed-off-by: Xavier Coulon <[email protected]> * fix test * remove unwanted changes * fix controller.TokenBlackBoxTest/TestLinkCallbackRedirects Signed-off-by: Xavier Coulon <[email protected]> * fix compilation error :/ Signed-off-by: Xavier Coulon <[email protected]> * fix compilation error #2 :/ Signed-off-by: Xavier Coulon <[email protected]> * renaming functions and types Signed-off-by: Xavier Coulon <[email protected]> * ISSUE-646 fixed TestExchangeWithCorrectCodeButNotApprovedUserOK Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed TestLinkOK Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed more tests Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed TestExchangeWithCorrectRefreshTokenOK Signed-off-by: Shane Bryzak <[email protected]> * fix TestExchangeWithCorrectCodeOK Signed-off-by: Xavier Coulon <[email protected]> * fix compilation errors on unit-tests Signed-off-by: Xavier Coulon <[email protected]> * ISSUE-646 fix golangci-lint errors Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 removed login dir Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 merged changes from issue #698 Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed end to end test Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 cleanup Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 added user_profile_blackbox_test Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 minor test change Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 minor Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 merge master Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 added setup to user profile test Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed go format Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 removed redundant function Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 added support for empty factory wrappers at runtime Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 go format Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 added redirect URL to oauth code exchange Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fix redirect url for login callback Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 format go code Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 removed unused param Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fix test Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 go format Signed-off-by: Shane Bryzak <[email protected]> * go fmt Signed-off-by: Xavier Coulon <[email protected]> * simplify code Signed-off-by: Xavier Coulon <[email protected]> * ISSUE-646 added tests for resource type scope Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 go format Signed-off-by: Shane Bryzak <[email protected]> * use DEFERRABLE constraints to clean the data after tests Signed-off-by: Xavier Coulon <[email protected]> * ISSUE-646 go fmt Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 re-add generated files Signed-off-by: Shane Bryzak <[email protected]> * apply review comments Signed-off-by: Xavier Coulon <[email protected]> * test the 'GetLastModified()' method on DefaultRoleMapping Signed-off-by: Xavier Coulon <[email protected]> * ISSUE-646 removed update of oauth user profile Signed-off-by: Shane Bryzak <[email protected]> * remove empty deferred func Signed-off-by: Xavier Coulon <[email protected]> * ISSUE-646 remove generated code Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 don't create new token managers Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 go fmt Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 added test Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 go fmt Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed test Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 removed unused code Signed-off-by: Shane Bryzak <[email protected]> * make constraint explicitly 'DEFERRABLE INITIALLY IMMEDIATE' Signed-off-by: Xavier Coulon <[email protected]> * redirect to 'redirectURL' in case of error fix and test login/callback controller Signed-off-by: Xavier Coulon <[email protected]> * return 500 error when callback failed Signed-off-by: Xavier Coulon <[email protected]> * make sure preview account can be approved Signed-off-by: Xavier Coulon <[email protected]> * add deployment for cluster svc Signed-off-by: Xavier Coulon <[email protected]> * ISSUE-646 fixed golangci issues, fixed token blackbox test Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 go fmt Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 test relinking of external tokens Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 go fmt Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 removed jwk functions Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 moved unused function Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 improved logging Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 renamed migration script Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 go fmt Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 put migration script in correct directory Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed migration test Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 merged Alexey's PR, updated format to go 1.11 Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fix migration test Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 oops, fixed filename Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed resource roles test Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fix golangci issues Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fix more golangci issue Signed-off-by: Shane Bryzak <[email protected]> * ISSUE-646 fixed review issues Signed-off-by: Shane Bryzak <[email protected]>
- Loading branch information