issue-9, README file enhancements. #11
Conversation
|
+1 to have one readme. |
|
Can one of the admins verify this patch? |
|
|
||
| `$ docker build --build-arg OPERATING_MODE=clustered --tag IMAGE_NAME .` | ||
|
|
||
| Note that, this docker image installs the certificate to securely talk to OpenShift Online. |
There was a problem hiding this comment.
this part might not be required anymore, we're currently testing it.
There was a problem hiding this comment.
I mean the certificate installation
There was a problem hiding this comment.
Yeah.. this is why this PR is now conflicting. This section has been removed from the readme. But we still need to verify if it's really not needed anymore.
There was a problem hiding this comment.
I still needed to do it to test oAuth between KC and minishift, before installing the certificate my log was full of certificate-related errors and nothing worked.
README.md
Outdated
| To build this image it is necessary to have previously generated the executables of this | ||
| project. To do this, run the following Maven command in the almighty/keycloak repository: | ||
|
|
||
| `$ mvn clean install -DskipTests -pl :keycloak-server-dist -am -P distribution` |
There was a problem hiding this comment.
Here we are building the keycloak-server-dist, but if it is the first time you run this project. You need $ mvn clean install -DskipTests -am -P distribution
There was a problem hiding this comment.
I've added a note as such in the readme.
Signed-off-by: Shane Bryzak <[email protected]>
|
Can one of the admins verify this patch? |
|
|
||
| In the content of the Dockerfile, you can find these ENV variables: | ||
| ``` | ||
| ENV OSO_ADDRESS tsrv.devshift.net:8443 |
There was a problem hiding this comment.
We don't need certificate handling anymore
|
Can one of the admins verify this patch? |
|
@sbryzak can you please update this PR? |
Signed-off-by: Shane Bryzak [email protected]